[flutter_appauth] Fix for logout crash while app is on background #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnKim7
changed the title
|
on react native version of app auth wrapper, there is such kind of null check. And as it says it prevents from app crash. |
MaikuB
reviewed
Jan 20, 2024
...appauth/android/src/main/java/io/crossingthestreams/flutterappauth/FlutterAppauthPlugin.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on Android Ii user does logout and while logging out user closes the browser and go background and come back, the app crashes. It happens because flutter activity waits for intent not to be null, but it is null. We need to add null check on activity result method on Android.
Related issue: #459 (comment)