Skip to content

Create LICENSE #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2018
Merged

Create LICENSE #6

merged 2 commits into from
Jun 1, 2018

Conversation

s-celles
Copy link
Contributor

@s-celles s-celles commented May 31, 2018

@MajicDesigns
Copy link
Owner

Why do you think it is necessary to include the licence? The type of licence is already mentioned in the .h file.

@per1234
Copy link

per1234 commented May 31, 2018

GitHub does have some neat features that are enabled by having a dedicated license file in the root of the repository. GitHub uses this file to detect the license of the repository and:

  • Displays this on the info bar of the repository home page.
  • Allows filtering searches by license type.
  • Provides license information via the GitHub API.

https://help.github.com/articles/licensing-a-repository/

As for the license field in library.properties, there is some information here:
arduino/Arduino#6646 (comment)
Unfortunately there has not been any information from the Arduino team as to the official support for this field.

@scls19fr, since it looks like you're submitting a lot of this sort of PR I recommend you to start providing an explanation of why this is beneficial. That should prevent any confusion and make it more likely that your proposals will be accepted.

@MajicDesigns MajicDesigns self-assigned this May 31, 2018
@MajicDesigns MajicDesigns added the enhancement Enhancement or new feature suggestion label May 31, 2018
@MajicDesigns MajicDesigns merged commit aefd01b into MajicDesigns:master Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or new feature suggestion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants