Skip to content

Fix "pretty" mode tests #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 26, 2018
Merged

Fix "pretty" mode tests #112

merged 3 commits into from
Apr 26, 2018

Conversation

denzp
Copy link
Contributor

@denzp denzp commented Apr 25, 2018

Adjust to Rust command line changes related to "pretty" mode tests.

Fixes #111

@laumann
Copy link
Collaborator

laumann commented Apr 26, 2018

Thanks! I noticed the AppVeyor build doesn't actually run the cargo test in the test-project (I need to fix that), so I ran it myself. Nightly works fine (as I expected), but running cargo test --features stable doesn't work because the -Z option is not allowed on stable.

Does this break using compiletest on stable? Or is it just not possible to use "pretty" mode on stable? I would be OK with the latter, but the former would bother some users.

@laumann
Copy link
Collaborator

laumann commented Apr 26, 2018

Hmm, I think I answered my own question: One of the removed lines is

-            .arg("-Zunstable-options")

which already shouldn't work on stable, so I think "pretty" works on nightly only (but the other modes are fine).

Do you agree? If so, I'll merge this and release a new version.

@denzp
Copy link
Contributor Author

denzp commented Apr 26, 2018

Right, before it was -Zunstable-options now it's -Zunpretty. According to the error message, unfortunately, these test even before couldn only be used on nightly:

error: the option `Z` is only accepted on the nightly compiler

I'm going to add one more commit to disable the tests on stable.

@laumann
Copy link
Collaborator

laumann commented Apr 26, 2018

Beautiful, thanks!

@laumann laumann merged commit 9e1b082 into Manishearth:master Apr 26, 2018
@laumann
Copy link
Collaborator

laumann commented Apr 26, 2018

0.3.11 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants