MDEV-37948 ALTER TABLE TRUNCATE PARTITION requires only DROP privilege#4601
Open
FarihaIS wants to merge 1 commit intoMariaDB:12.2from
Open
MDEV-37948 ALTER TABLE TRUNCATE PARTITION requires only DROP privilege#4601FarihaIS wants to merge 1 commit intoMariaDB:12.2from
FarihaIS wants to merge 1 commit intoMariaDB:12.2from
Conversation
ALTER TABLE ... TRUNCATE PARTITION only checks for DROP privilege, while ALTER TABLE ... DROP PARTITION correctly requires both DROP and ALTER privileges. This is inconsistent and a privilege issue since TRUNCATE PARTITION is an ALTER TABLE statement. Add ALTER privilege check to TRUNCATE PARTITION to match DROP PARTITION behavior and documentation. All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ALTER TABLE ... TRUNCATE PARTITIONonly checks forDROPprivilege, whileALTER TABLE ... DROP PARTITIONcorrectly requires bothDROPandALTERprivileges. This is inconsistent and a privilege issue sinceTRUNCATE PARTITIONis anALTER TABLEstatement.Add
ALTERprivilege check toTRUNCATE PARTITIONto matchDROP PARTITIONbehavior and documentation.Release Notes
N/A
How can this PR be tested?
Execute the
main.partition_granttest in mysql-test-run. This commit adds a test inpartition_grant.test.Before the fix
A user with only
DROPprivilege can truncate partitions:After the fix
A user needs both
ALTERandDROPprivileges to truncate partitions:Basing the PR against the correct MariaDB version
Copyright
All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.