Fix code out of order in do move after z homing#28395
Open
ellensp wants to merge 2 commits into
Open
Conversation
|
This fixed my latest bugfix build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In do_move_after_z_homing Z_POST_CLEARANCE is defined after the code that wants to use it (if not using proui)
This causes Z raise after after homing not to work.
I re ordered the code a little
After the code re order Z_POST_CLEARANCE is always defined, so I removed an redundant #ifdef Z_POST_CLEARANCE block and the else case that is never called.
Requirements
A Z axis, if a probe if present it is not used for homing, home using a z-stop
not using proui (as it defines its own Z_POST_CLEARANCE)
Benefits
Z raise after after homing functions correctly.
Configurations
Confgs from the issue
https://github.com/user-attachments/files/26753084/Configuration.zip
Related Issues