Skip to content

Update differential-dataflow #19027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2023
Merged

Update differential-dataflow #19027

merged 2 commits into from
Apr 28, 2023

Conversation

teskje
Copy link
Contributor

@teskje teskje commented Apr 28, 2023 •
edited
Loading

This is to pick up TimelyDataflow/differential-dataflow#386

Also includes a regression test for MaterializeInc/database-issues#5550.

Motivation

  • This PR fixes a recognized bug.

Fixes https://github.com/MaterializeInc/database-issues/issues/5550.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • This PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way) and therefore is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:
    • N/A

@teskje teskje marked this pull request as draft April 28, 2023 08:14
@teskje teskje marked this pull request as ready for review April 28, 2023 08:24
@teskje teskje requested review from a team, philip-stoev and ggevay April 28, 2023 08:24
philip-stoev
philip-stoev approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@philip-stoev philip-stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@teskje teskje merged commit 65fd205 into MaterializeInc:main Apr 28, 2023
@teskje teskje deleted the update-dd branch April 28, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philip-stoev philip-stoev philip-stoev approved these changes

@ggevay ggevay Awaiting requested review from ggevay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teskje @philip-stoev