-
Notifications
You must be signed in to change notification settings - Fork 5
Description
Specification
In the NodeManager we make use of 3 handlers with the task system. Their handler IDs are public read only properties that are public readonly handlerId = '${this.constructor.name}.${this.handler.name}' as HandlerId. this.handler is an async arrow function used as a handler for a task. The handlerId should be 'NodeManager.handler'.
The problem is, in some cases the this.handler.name has the value of '' as an empty string. The weird thing is, in a simple test where we just construct the NodeManager and check it we get the expected values. When we do more complex tests within the nodes domain we see the empty strings resulting in errors.
My first guess is it's the same decorator problem we had to fix for the this.constructor.name when we switched to SWC. I'm guessing when we start the NodeManager it overwrites the property names? More exploration on this is needed.
Additional context
- Related Integrate TaskManager into NodeGraph and Discovery #445
- Related comments ci: merge staging to master #411 (comment)
Tasks
- Determine the cause of the problem.
- Fix property names so the are not empty strings.