Skip to content

Integrate js-lint and removing old linting elements #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025

Conversation

CDeltakai
Copy link
Contributor

@CDeltakai CDeltakai commented Apr 22, 2025

Description

This PR integrates the new js-lint package and removes old linting elements

Issues Fixed

Tasks

  • 1. Integrate js-lint and ensure it works as expected.
  • 2. Remove old linting elements as they are no longer needed.

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@CDeltakai CDeltakai self-assigned this Apr 22, 2025
@CDeltakai CDeltakai requested a review from aryanjassal May 13, 2025 07:53
@CDeltakai
Copy link
Contributor Author

@aryanjassal Could you just give it a quick check for the latest commit? I just removed the await from some of the for loops since the linter was saying that it was incorrect because the iterables were synchronous. Just want to make sure this doesn't break functionality before merging.

@CDeltakai CDeltakai merged commit 3b02c97 into staging May 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

js-rpc: Integrate js-lint
1 participant