Skip to content

Support Python 3.8. #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2018
Merged

Support Python 3.8. #41

merged 2 commits into from
Oct 25, 2018

Conversation

serhiy-storchaka
Copy link
Contributor

No description provided.

@MatthieuDartiailh MatthieuDartiailh self-requested a review October 16, 2018 13:17
MatthieuDartiailh
MatthieuDartiailh requested changes Oct 16, 2018
View reviewed changes
bytecode/instr.py Outdated
arg = (self._arg if isinstance(self._arg, int) else
0 if self._opcode >= _opcode.HAVE_ARGUMENT else None)
return dis.stack_effect(self._opcode, arg)
0 if self._opcode >= _opcode.HAVE_ARGUMENT else None)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PEP8 indent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Also duplicated tests for 3.8.

@codecov-io
Copy link

codecov-io commented Oct 16, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@f63b5b9). Click here to learn what that means.
The diff coverage is 64.91%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #41   +/-   ##
=========================================
  Coverage          ?   92.99%           
=========================================
  Files             ?       17           
  Lines             ?     2655           
  Branches          ?        0           
=========================================
  Hits              ?     2469           
  Misses            ?      186           
  Partials          ?        0
Impacted Files Coverage Δ
bytecode/tests/test_cfg.py 97.1% <58.82%> (ø)
bytecode/tests/test_peephole_opt.py 90.86% <60%> (ø)
bytecode/instr.py 93.62% <90%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f63b5b9...29ba6aa. Read the comment docs.

@MatthieuDartiailh
Copy link
Owner

This was broken by #43

@serhiy-storchaka serhiy-storchaka mentioned this pull request Oct 19, 2018
Closed
@MatthieuDartiailh
Copy link
Owner

MatthieuDartiailh commented Oct 19, 2018 •
edited
Loading

@serhiy-storchaka could you point me to the bpo discussing the changes in the bytecode that require to change the tests (for my own education) ?

@serhiy-storchaka
Copy link
Contributor Author

This is mainly https://bugs.python.org/issue17611 (PR python/cpython#5006). SETUP_LOOP no longer used for loops, BREAK_LOOP is replaced with a direct jump, etc. These opcodes have been removed at all.

@MatthieuDartiailh
Copy link
Owner

I will merge now and open a new issue for updating the documentation. Thanks @serhiy-storchaka

@MatthieuDartiailh MatthieuDartiailh merged commit aa2d29f into MatthieuDartiailh:master Oct 25, 2018
@MatthieuDartiailh MatthieuDartiailh mentioned this pull request Oct 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MatthieuDartiailh MatthieuDartiailh MatthieuDartiailh requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@serhiy-storchaka @codecov-io @MatthieuDartiailh