-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Open
Labels
api-breakThis issue/PR breaks the API and must wait for a new major versionThis issue/PR breaks the API and must wait for a new major versioncomponent-x509size-xsEstimated task size: extra small (a few hours at most)Estimated task size: extra small (a few hours at most)
Description
Suggested enhancement
int mbedtls_x509write_crt_set_serial_raw(mbedtls_x509write_cert *ctx,
unsigned char *serial, size_t serial_len)
should be
int mbedtls_x509write_crt_set_serial_raw(mbedtls_x509write_cert *ctx,
const unsigned char *serial, size_t serial_len)
Justification
I don't see any reason why mbedtls_x509write_crt_set_serial_raw() cannot take a const unsigned char *serial as argument. The rest of the api seems to take const pointers.
Metadata
Metadata
Assignees
Labels
api-breakThis issue/PR breaks the API and must wait for a new major versionThis issue/PR breaks the API and must wait for a new major versioncomponent-x509size-xsEstimated task size: extra small (a few hours at most)Estimated task size: extra small (a few hours at most)
Type
Projects
Status
Implementation needed
Status
1.0/4.0 SHOULDs