Skip to content

mbedtls_x509write_crt_set_serial_raw() should take const serial buffer #10310

@fwh-dc

Description

@fwh-dc

Suggested enhancement

int mbedtls_x509write_crt_set_serial_raw(mbedtls_x509write_cert *ctx,
unsigned char *serial, size_t serial_len)

should be
int mbedtls_x509write_crt_set_serial_raw(mbedtls_x509write_cert *ctx,
const unsigned char *serial, size_t serial_len)

Justification

I don't see any reason why mbedtls_x509write_crt_set_serial_raw() cannot take a const unsigned char *serial as argument. The rest of the api seems to take const pointers.

Metadata

Metadata

Assignees

No one assigned

    Labels

    api-breakThis issue/PR breaks the API and must wait for a new major versioncomponent-x509size-xsEstimated task size: extra small (a few hours at most)

    Projects

    Status

    Implementation needed

    Status

    1.0/4.0 SHOULDs

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions