Fixed compilation on windows when MBEDTLS_HAVE_TIME is disabled but MBEDTLS_FS_IO is enabled #10126
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In case of failure it makes sense to provide the complete environment information: library version or commit, configuration, compiler. It seems my tests with the current development head were not clean enough, because |
|
Thanks for this, it seems that we indeed miss in x509_crt.c the inclusion of |
ronald-cron-arm
requested changes
Apr 16, 2025
Cryru
force-pushed
the
development
branch
2 times, most recently
from
d6b8c85 to
57b68c1
Compare
|
Added the requested changes and DCO. |
ronald-cron-arm
requested changes
Apr 17, 2025
…BEDTLS_FS_IO is enabled Signed-off-by: Vlad Abadzhiev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x509_crt does not compile when the MBEDTLS_HAVE_TIME option is disabled and the MBEDTLS_FS_IO is enabled because the windows.h header isn't included and MAX_PATH and other symbols (usage: mbedtls_x509_crt_parse_path) cannot be found.