Skip to content

Video: bundle JS and CSS files as single file #6124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2025
Merged

Conversation

stsrki
Copy link
Collaborator

@stsrki stsrki commented May 27, 2025

Based on the comment from vidstack/player#1560 (comment)

I have made changes to how we import vidstack files. Now everything is prebundled, and there is no need to manually define chunks.

This PR:

  • removes all chunks
  • removes vidstack and plyr files
  • adds new bundled files

I have also created a new project for future reference https://github.com/stsrki/vidstack-bundle

@stsrki stsrki requested a review from tesar-tech May 27, 2025 08:35
@tesar-tech
Copy link
Collaborator

I tested the video player and nothing went wrong.
I am glad this is done as it removes a lot from the repo.

Maybe I would consider to put the build "project" under the build folder in Blazorise.Video as it will be used with every js update - it is part of blazorise build step time to time.

@stsrki
Copy link
Collaborator Author

stsrki commented Jun 1, 2025

Maybe I would consider to put the build "project" under the build folder in Blazorise.Video as it will be used with every js update - it is part of blazorise build step time to time.

I'm not a fan of bringing the JS build process into the Blazorise codebase. Better to keep it out.

@stsrki stsrki changed the title Video: bundle JS and CSS files Video: bundle JS and CSS files as single file Jun 2, 2025
@stsrki stsrki merged commit e770328 into rel-1.7 Jun 2, 2025
2 checks passed
@stsrki stsrki deleted the rel-1.7-video-bundle branch June 2, 2025 09:05
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants