-
-
Notifications
You must be signed in to change notification settings - Fork 234
feat: TEMP - testing moving out snap historical price logic out from snaps #5938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
// Add assertion similar to snap | ||
assertStruct(response, GetHistoricalPricesResponseStruct); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validation total is around 1s.
Do we need such strict validation in our snap or here? This is our own API & we know the shape. Also if the shape was incorrect, it would fail elsewhere
DO NOT MERGE - this was a test
https://www.loom.com/share/04ed970983194a9c8396bc568289197c
Explanation
References
Changelog
Checklist