Seedless controller: store keyring encryption key instead of password #5995

matthiasgeihs · 2025-06-18T08:08:57Z

Explanation

It has been discussed that the seedless controller should no longer store and recover the vault password, instead it should store and recover the vault encryption key for the purpose of vault recovery in case of a global password change.

Breaking

Added submitGlobalPassword, storeKeyringEncryptionKey, and loadKeyringEncryptionKey.
Changed syncLatestGlobalPassword.
Removed recoverCurrentDevicePassword.

References

Previously, seedless onboarding was backing up the keyring password to allow for vault recovery after a password change. Now we backup the keyring encryption key.

See the ADR for more details.
This is part of the implementation of option 6.

Changelog

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

matthiasgeihs · 2025-06-18T08:18:21Z

@metamaskbot publish-preview

github-actions · 2025-06-18T08:23:46Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/account-tree-controller": "0.1.1-preview-e149187d",
  "@metamask-previews/accounts-controller": "30.0.0-preview-e149187d",
  "@metamask-previews/address-book-controller": "6.1.0-preview-e149187d",
  "@metamask-previews/announcement-controller": "7.0.3-preview-e149187d",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-e149187d",
  "@metamask-previews/approval-controller": "7.1.3-preview-e149187d",
  "@metamask-previews/assets-controllers": "68.2.0-preview-e149187d",
  "@metamask-previews/base-controller": "8.0.1-preview-e149187d",
  "@metamask-previews/bridge-controller": "32.1.2-preview-e149187d",
  "@metamask-previews/bridge-status-controller": "29.1.1-preview-e149187d",
  "@metamask-previews/build-utils": "3.0.3-preview-e149187d",
  "@metamask-previews/chain-agnostic-permission": "0.7.1-preview-e149187d",
  "@metamask-previews/composable-controller": "11.0.0-preview-e149187d",
  "@metamask-previews/controller-utils": "11.10.0-preview-e149187d",
  "@metamask-previews/delegation-controller": "0.4.0-preview-e149187d",
  "@metamask-previews/earn-controller": "1.1.1-preview-e149187d",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-e149187d",
  "@metamask-previews/ens-controller": "16.0.0-preview-e149187d",
  "@metamask-previews/error-reporting-service": "1.0.0-preview-e149187d",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-e149187d",
  "@metamask-previews/foundryup": "1.0.0-preview-e149187d",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-e149187d",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-e149187d",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-e149187d",
  "@metamask-previews/keyring-controller": "22.0.2-preview-e149187d",
  "@metamask-previews/logging-controller": "6.0.4-preview-e149187d",
  "@metamask-previews/message-manager": "12.0.1-preview-e149187d",
  "@metamask-previews/multichain-api-middleware": "0.4.0-preview-e149187d",
  "@metamask-previews/multichain-network-controller": "0.8.0-preview-e149187d",
  "@metamask-previews/multichain-transactions-controller": "2.0.0-preview-e149187d",
  "@metamask-previews/name-controller": "8.0.3-preview-e149187d",
  "@metamask-previews/network-controller": "23.6.0-preview-e149187d",
  "@metamask-previews/notification-services-controller": "10.0.0-preview-e149187d",
  "@metamask-previews/permission-controller": "11.0.6-preview-e149187d",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-e149187d",
  "@metamask-previews/phishing-controller": "12.6.0-preview-e149187d",
  "@metamask-previews/polling-controller": "13.0.0-preview-e149187d",
  "@metamask-previews/preferences-controller": "18.1.0-preview-e149187d",
  "@metamask-previews/profile-sync-controller": "17.1.0-preview-e149187d",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-e149187d",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-e149187d",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-e149187d",
  "@metamask-previews/sample-controllers": "0.1.0-preview-e149187d",
  "@metamask-previews/seedless-onboarding-controller": "1.0.0-preview-e149187d",
  "@metamask-previews/selected-network-controller": "22.1.0-preview-e149187d",
  "@metamask-previews/signature-controller": "30.0.0-preview-e149187d",
  "@metamask-previews/token-search-discovery-controller": "3.3.0-preview-e149187d",
  "@metamask-previews/transaction-controller": "57.3.0-preview-e149187d",
  "@metamask-previews/user-operation-controller": "36.0.0-preview-e149187d"
}

matthiasgeihs · 2025-06-18T09:40:32Z

@metamaskbot publish-preview

github-actions · 2025-06-18T09:46:09Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/account-tree-controller": "0.1.1-preview-01cb507d",
  "@metamask-previews/accounts-controller": "30.0.0-preview-01cb507d",
  "@metamask-previews/address-book-controller": "6.1.0-preview-01cb507d",
  "@metamask-previews/announcement-controller": "7.0.3-preview-01cb507d",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-01cb507d",
  "@metamask-previews/approval-controller": "7.1.3-preview-01cb507d",
  "@metamask-previews/assets-controllers": "68.2.0-preview-01cb507d",
  "@metamask-previews/base-controller": "8.0.1-preview-01cb507d",
  "@metamask-previews/bridge-controller": "32.1.2-preview-01cb507d",
  "@metamask-previews/bridge-status-controller": "29.1.1-preview-01cb507d",
  "@metamask-previews/build-utils": "3.0.3-preview-01cb507d",
  "@metamask-previews/chain-agnostic-permission": "0.7.1-preview-01cb507d",
  "@metamask-previews/composable-controller": "11.0.0-preview-01cb507d",
  "@metamask-previews/controller-utils": "11.10.0-preview-01cb507d",
  "@metamask-previews/delegation-controller": "0.4.0-preview-01cb507d",
  "@metamask-previews/earn-controller": "1.1.1-preview-01cb507d",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-01cb507d",
  "@metamask-previews/ens-controller": "16.0.0-preview-01cb507d",
  "@metamask-previews/error-reporting-service": "1.0.0-preview-01cb507d",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-01cb507d",
  "@metamask-previews/foundryup": "1.0.0-preview-01cb507d",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-01cb507d",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-01cb507d",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-01cb507d",
  "@metamask-previews/keyring-controller": "22.0.2-preview-01cb507d",
  "@metamask-previews/logging-controller": "6.0.4-preview-01cb507d",
  "@metamask-previews/message-manager": "12.0.1-preview-01cb507d",
  "@metamask-previews/multichain-api-middleware": "0.4.0-preview-01cb507d",
  "@metamask-previews/multichain-network-controller": "0.8.0-preview-01cb507d",
  "@metamask-previews/multichain-transactions-controller": "2.0.0-preview-01cb507d",
  "@metamask-previews/name-controller": "8.0.3-preview-01cb507d",
  "@metamask-previews/network-controller": "23.6.0-preview-01cb507d",
  "@metamask-previews/notification-services-controller": "10.0.0-preview-01cb507d",
  "@metamask-previews/permission-controller": "11.0.6-preview-01cb507d",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-01cb507d",
  "@metamask-previews/phishing-controller": "12.6.0-preview-01cb507d",
  "@metamask-previews/polling-controller": "13.0.0-preview-01cb507d",
  "@metamask-previews/preferences-controller": "18.1.0-preview-01cb507d",
  "@metamask-previews/profile-sync-controller": "17.1.0-preview-01cb507d",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-01cb507d",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-01cb507d",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-01cb507d",
  "@metamask-previews/sample-controllers": "0.1.0-preview-01cb507d",
  "@metamask-previews/seedless-onboarding-controller": "1.0.0-preview-01cb507d",
  "@metamask-previews/selected-network-controller": "22.1.0-preview-01cb507d",
  "@metamask-previews/signature-controller": "30.0.0-preview-01cb507d",
  "@metamask-previews/token-search-discovery-controller": "3.3.0-preview-01cb507d",
  "@metamask-previews/transaction-controller": "57.3.0-preview-01cb507d",
  "@metamask-previews/user-operation-controller": "36.0.0-preview-01cb507d"
}

packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts

matthiasgeihs · 2025-06-19T10:30:21Z

@metamaskbot publish-preview

github-actions · 2025-06-19T10:35:56Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/account-tree-controller": "0.1.1-preview-abf6aaef",
  "@metamask-previews/accounts-controller": "30.0.0-preview-abf6aaef",
  "@metamask-previews/address-book-controller": "6.1.0-preview-abf6aaef",
  "@metamask-previews/announcement-controller": "7.0.3-preview-abf6aaef",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-abf6aaef",
  "@metamask-previews/approval-controller": "7.1.3-preview-abf6aaef",
  "@metamask-previews/assets-controllers": "68.2.0-preview-abf6aaef",
  "@metamask-previews/base-controller": "8.0.1-preview-abf6aaef",
  "@metamask-previews/bridge-controller": "32.1.2-preview-abf6aaef",
  "@metamask-previews/bridge-status-controller": "29.1.1-preview-abf6aaef",
  "@metamask-previews/build-utils": "3.0.3-preview-abf6aaef",
  "@metamask-previews/chain-agnostic-permission": "0.7.1-preview-abf6aaef",
  "@metamask-previews/composable-controller": "11.0.0-preview-abf6aaef",
  "@metamask-previews/controller-utils": "11.10.0-preview-abf6aaef",
  "@metamask-previews/delegation-controller": "0.4.0-preview-abf6aaef",
  "@metamask-previews/earn-controller": "1.1.1-preview-abf6aaef",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-abf6aaef",
  "@metamask-previews/ens-controller": "16.0.0-preview-abf6aaef",
  "@metamask-previews/error-reporting-service": "1.0.0-preview-abf6aaef",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-abf6aaef",
  "@metamask-previews/foundryup": "1.0.0-preview-abf6aaef",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-abf6aaef",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-abf6aaef",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-abf6aaef",
  "@metamask-previews/keyring-controller": "22.0.2-preview-abf6aaef",
  "@metamask-previews/logging-controller": "6.0.4-preview-abf6aaef",
  "@metamask-previews/message-manager": "12.0.1-preview-abf6aaef",
  "@metamask-previews/multichain-api-middleware": "0.4.0-preview-abf6aaef",
  "@metamask-previews/multichain-network-controller": "0.8.0-preview-abf6aaef",
  "@metamask-previews/multichain-transactions-controller": "2.0.0-preview-abf6aaef",
  "@metamask-previews/name-controller": "8.0.3-preview-abf6aaef",
  "@metamask-previews/network-controller": "23.6.0-preview-abf6aaef",
  "@metamask-previews/notification-services-controller": "10.0.0-preview-abf6aaef",
  "@metamask-previews/permission-controller": "11.0.6-preview-abf6aaef",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-abf6aaef",
  "@metamask-previews/phishing-controller": "12.6.0-preview-abf6aaef",
  "@metamask-previews/polling-controller": "13.0.0-preview-abf6aaef",
  "@metamask-previews/preferences-controller": "18.1.0-preview-abf6aaef",
  "@metamask-previews/profile-sync-controller": "17.1.0-preview-abf6aaef",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-abf6aaef",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-abf6aaef",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-abf6aaef",
  "@metamask-previews/sample-controllers": "0.1.0-preview-abf6aaef",
  "@metamask-previews/seedless-onboarding-controller": "1.0.0-preview-abf6aaef",
  "@metamask-previews/selected-network-controller": "22.1.0-preview-abf6aaef",
  "@metamask-previews/signature-controller": "30.0.0-preview-abf6aaef",
  "@metamask-previews/token-search-discovery-controller": "3.3.0-preview-abf6aaef",
  "@metamask-previews/transaction-controller": "57.3.0-preview-abf6aaef",
  "@metamask-previews/user-operation-controller": "36.0.0-preview-abf6aaef"
}

matthiasgeihs · 2025-06-19T17:13:30Z

@metamaskbot publish-preview

github-actions · 2025-06-19T17:19:25Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/account-tree-controller": "0.1.1-preview-4e3fd4c0",
  "@metamask-previews/accounts-controller": "30.0.0-preview-4e3fd4c0",
  "@metamask-previews/address-book-controller": "6.1.0-preview-4e3fd4c0",
  "@metamask-previews/announcement-controller": "7.0.3-preview-4e3fd4c0",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-4e3fd4c0",
  "@metamask-previews/approval-controller": "7.1.3-preview-4e3fd4c0",
  "@metamask-previews/assets-controllers": "68.2.0-preview-4e3fd4c0",
  "@metamask-previews/base-controller": "8.0.1-preview-4e3fd4c0",
  "@metamask-previews/bridge-controller": "32.1.2-preview-4e3fd4c0",
  "@metamask-previews/bridge-status-controller": "29.1.1-preview-4e3fd4c0",
  "@metamask-previews/build-utils": "3.0.3-preview-4e3fd4c0",
  "@metamask-previews/chain-agnostic-permission": "0.7.1-preview-4e3fd4c0",
  "@metamask-previews/composable-controller": "11.0.0-preview-4e3fd4c0",
  "@metamask-previews/controller-utils": "11.10.0-preview-4e3fd4c0",
  "@metamask-previews/delegation-controller": "0.4.0-preview-4e3fd4c0",
  "@metamask-previews/earn-controller": "1.1.1-preview-4e3fd4c0",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-4e3fd4c0",
  "@metamask-previews/ens-controller": "16.0.0-preview-4e3fd4c0",
  "@metamask-previews/error-reporting-service": "1.0.0-preview-4e3fd4c0",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-4e3fd4c0",
  "@metamask-previews/foundryup": "1.0.0-preview-4e3fd4c0",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-4e3fd4c0",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-4e3fd4c0",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-4e3fd4c0",
  "@metamask-previews/keyring-controller": "22.0.2-preview-4e3fd4c0",
  "@metamask-previews/logging-controller": "6.0.4-preview-4e3fd4c0",
  "@metamask-previews/message-manager": "12.0.1-preview-4e3fd4c0",
  "@metamask-previews/multichain-api-middleware": "0.4.0-preview-4e3fd4c0",
  "@metamask-previews/multichain-network-controller": "0.8.0-preview-4e3fd4c0",
  "@metamask-previews/multichain-transactions-controller": "2.0.0-preview-4e3fd4c0",
  "@metamask-previews/name-controller": "8.0.3-preview-4e3fd4c0",
  "@metamask-previews/network-controller": "23.6.0-preview-4e3fd4c0",
  "@metamask-previews/notification-services-controller": "10.0.0-preview-4e3fd4c0",
  "@metamask-previews/permission-controller": "11.0.6-preview-4e3fd4c0",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-4e3fd4c0",
  "@metamask-previews/phishing-controller": "12.6.0-preview-4e3fd4c0",
  "@metamask-previews/polling-controller": "13.0.0-preview-4e3fd4c0",
  "@metamask-previews/preferences-controller": "18.1.0-preview-4e3fd4c0",
  "@metamask-previews/profile-sync-controller": "17.1.0-preview-4e3fd4c0",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-4e3fd4c0",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-4e3fd4c0",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-4e3fd4c0",
  "@metamask-previews/sample-controllers": "0.1.0-preview-4e3fd4c0",
  "@metamask-previews/seedless-onboarding-controller": "1.0.0-preview-4e3fd4c0",
  "@metamask-previews/selected-network-controller": "22.1.0-preview-4e3fd4c0",
  "@metamask-previews/signature-controller": "30.0.0-preview-4e3fd4c0",
  "@metamask-previews/token-search-discovery-controller": "3.3.0-preview-4e3fd4c0",
  "@metamask-previews/transaction-controller": "57.3.0-preview-4e3fd4c0",
  "@metamask-previews/user-operation-controller": "36.0.0-preview-4e3fd4c0"
}

packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts

matthiasgeihs · 2025-06-20T07:56:28Z

@metamaskbot publish-preview

github-actions · 2025-06-20T08:01:54Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/account-tree-controller": "0.1.1-preview-3636a128",
  "@metamask-previews/accounts-controller": "30.0.0-preview-3636a128",
  "@metamask-previews/address-book-controller": "6.1.0-preview-3636a128",
  "@metamask-previews/announcement-controller": "7.0.3-preview-3636a128",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-3636a128",
  "@metamask-previews/approval-controller": "7.1.3-preview-3636a128",
  "@metamask-previews/assets-controllers": "68.2.0-preview-3636a128",
  "@metamask-previews/base-controller": "8.0.1-preview-3636a128",
  "@metamask-previews/bridge-controller": "32.1.2-preview-3636a128",
  "@metamask-previews/bridge-status-controller": "29.1.1-preview-3636a128",
  "@metamask-previews/build-utils": "3.0.3-preview-3636a128",
  "@metamask-previews/chain-agnostic-permission": "0.7.1-preview-3636a128",
  "@metamask-previews/composable-controller": "11.0.0-preview-3636a128",
  "@metamask-previews/controller-utils": "11.10.0-preview-3636a128",
  "@metamask-previews/delegation-controller": "0.4.0-preview-3636a128",
  "@metamask-previews/earn-controller": "1.1.1-preview-3636a128",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-3636a128",
  "@metamask-previews/ens-controller": "16.0.0-preview-3636a128",
  "@metamask-previews/error-reporting-service": "1.0.0-preview-3636a128",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-3636a128",
  "@metamask-previews/foundryup": "1.0.0-preview-3636a128",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-3636a128",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-3636a128",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-3636a128",
  "@metamask-previews/keyring-controller": "22.0.2-preview-3636a128",
  "@metamask-previews/logging-controller": "6.0.4-preview-3636a128",
  "@metamask-previews/message-manager": "12.0.1-preview-3636a128",
  "@metamask-previews/multichain-api-middleware": "0.4.0-preview-3636a128",
  "@metamask-previews/multichain-network-controller": "0.8.0-preview-3636a128",
  "@metamask-previews/multichain-transactions-controller": "2.0.0-preview-3636a128",
  "@metamask-previews/name-controller": "8.0.3-preview-3636a128",
  "@metamask-previews/network-controller": "23.6.0-preview-3636a128",
  "@metamask-previews/notification-services-controller": "10.0.0-preview-3636a128",
  "@metamask-previews/permission-controller": "11.0.6-preview-3636a128",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-3636a128",
  "@metamask-previews/phishing-controller": "12.6.0-preview-3636a128",
  "@metamask-previews/polling-controller": "13.0.0-preview-3636a128",
  "@metamask-previews/preferences-controller": "18.1.0-preview-3636a128",
  "@metamask-previews/profile-sync-controller": "17.1.0-preview-3636a128",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-3636a128",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-3636a128",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-3636a128",
  "@metamask-previews/sample-controllers": "0.1.0-preview-3636a128",
  "@metamask-previews/seedless-onboarding-controller": "1.0.0-preview-3636a128",
  "@metamask-previews/selected-network-controller": "22.1.0-preview-3636a128",
  "@metamask-previews/signature-controller": "30.0.0-preview-3636a128",
  "@metamask-previews/token-search-discovery-controller": "3.3.0-preview-3636a128",
  "@metamask-previews/transaction-controller": "57.3.0-preview-3636a128",
  "@metamask-previews/user-operation-controller": "36.0.0-preview-3636a128"
}

this is necessary to rehydrate vault after password change without knowledge of old password

This reverts commit b3b2e4c.

packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts

socket-security · 2025-06-23T12:32:16Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@metamask/toprf-secure-backup@0.3.2 ⏵ 0.4.0	⁺²		⁺¹²	⁺¹

View full report

himanshuchawla009

lgtm

packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts

himanshuchawla009

lgtm

matthiasgeihs force-pushed the mg/seedless/store-vault-key branch from 11e3287 to e149187 Compare June 18, 2025 08:14

matthiasgeihs changed the base branch from main to mg/keyring/export-key June 18, 2025 17:20

lwin-kyaw reviewed Jun 19, 2025

View reviewed changes

packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts Outdated Show resolved Hide resolved

lwin-kyaw reviewed Jun 19, 2025

View reviewed changes

packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts Outdated Show resolved Hide resolved

matthiasgeihs force-pushed the mg/seedless/store-vault-key branch from 01cb507 to abf6aae Compare June 19, 2025 10:27

chaitanyapotti added the team-web3auth label Jun 19, 2025

matthiasgeihs force-pushed the mg/seedless/store-vault-key branch 2 times, most recently from 9399e4f to 4e3fd4c Compare June 19, 2025 16:47

himanshuchawla009 requested changes Jun 20, 2025

View reviewed changes

matthiasgeihs force-pushed the mg/seedless/store-vault-key branch from 2dca1a5 to 3636a12 Compare June 20, 2025 07:54

matthiasgeihs force-pushed the mg/seedless/store-vault-key branch from 3636a12 to a088347 Compare June 20, 2025 07:59

matthiasgeihs force-pushed the mg/seedless/store-vault-key branch from a088347 to 35c6ef2 Compare June 20, 2025 08:16

matthiasgeihs force-pushed the mg/keyring/export-key branch from 369af94 to f2ef812 Compare June 20, 2025 08:21

matthiasgeihs force-pushed the mg/seedless/store-vault-key branch from 35c6ef2 to efdfa8c Compare June 20, 2025 08:23

matthiasgeihs marked this pull request as ready for review June 20, 2025 10:02

matthiasgeihs requested review from a team as code owners June 20, 2025 10:02

matthiasgeihs requested review from lwin-kyaw and himanshuchawla009 June 20, 2025 10:04

matthiasgeihs force-pushed the mg/keyring/export-key branch from fee5652 to 9688e86 Compare June 20, 2025 13:33

matthiasgeihs requested a review from a team as a code owner June 20, 2025 13:33

matthiasgeihs force-pushed the mg/seedless/store-vault-key branch from cd506c7 to a72257b Compare June 20, 2025 13:34

matthiasgeihs force-pushed the mg/keyring/export-key branch from 9688e86 to 3b7ffdd Compare June 21, 2025 10:51

Base automatically changed from mg/keyring/export-key to main June 21, 2025 10:57

matthiasgeihs added 12 commits June 21, 2025 13:18

store and recover keyring encryption key

4a114e2

update tests

2cbaae1

remove password check on change password

532a229

this is necessary to rehydrate vault after password change without knowledge of old password

explicit storeKeyringEncryptionKey

6d2fd97

Revert "update tests"

ff8c6fe

This reverts commit b3b2e4c.

update tests

1b8c32f

unlock with global password

8f119b2

update tests

e27a589

fixup function doc

c496701

fixup jsdoc

d16963c

syncLatestGlobalPassword: require unlocked controller

daae002

update CHANGELOG

b0f5338

matthiasgeihs force-pushed the mg/seedless/store-vault-key branch from a72257b to b0f5338 Compare June 21, 2025 11:18

himanshuchawla009 requested changes Jun 22, 2025

View reviewed changes

matthiasgeihs added 3 commits June 23, 2025 13:57

update toprf client

4d61e63

yarn allow-scripts auto

1ca0218

update tests

9b7a0ed

matthiasgeihs force-pushed the mg/seedless/store-vault-key branch from b1e7582 to 9b7a0ed Compare June 23, 2025 12:59

fixup

b905e15

himanshuchawla009 approved these changes Jun 23, 2025

View reviewed changes

himanshuchawla009 requested changes Jun 23, 2025

View reviewed changes

packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts Outdated Show resolved Hide resolved

packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts Show resolved Hide resolved

(fix) use pw enc key instead of enc key

6a55034

himanshuchawla009 approved these changes Jun 23, 2025

View reviewed changes

Merge branch 'main' into mg/seedless/store-vault-key

85f2f00

lwin-kyaw approved these changes Jun 24, 2025

View reviewed changes

Uh oh!

Seedless controller: store keyring encryption key instead of password #5995

Are you sure you want to change the base?

Seedless controller: store keyring encryption key instead of password #5995

Uh oh!

Conversation

matthiasgeihs commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation

References

Changelog

Checklist

Uh oh!

matthiasgeihs commented Jun 18, 2025

Uh oh!

github-actions bot commented Jun 18, 2025

Uh oh!

matthiasgeihs commented Jun 18, 2025

Uh oh!

github-actions bot commented Jun 18, 2025

Uh oh!

Uh oh!

Uh oh!

matthiasgeihs commented Jun 19, 2025

Uh oh!

github-actions bot commented Jun 19, 2025

Uh oh!

matthiasgeihs commented Jun 19, 2025

Uh oh!

github-actions bot commented Jun 19, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

matthiasgeihs commented Jun 20, 2025

Uh oh!

github-actions bot commented Jun 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

socket-security bot commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

himanshuchawla009 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

himanshuchawla009 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

matthiasgeihs commented Jun 18, 2025 •

edited

Loading

socket-security bot commented Jun 23, 2025 •

edited

Loading