Skip to content

[Delegation Toolkit] Update docs #2116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[Delegation Toolkit] Update docs #2116

wants to merge 10 commits into from

Conversation

AyushBherwani1998
Copy link
Member

Description

Update delegation toolkit docs to latest v0.12.0 release

Preview

Checklist

Complete this checklist before merging your PR:

  • If this PR contains a major change to the documentation content, I have added an entry to the top of the "What's new?" page.
  • The proposed changes have been reviewed and approved by a member of the documentation team.

@AyushBherwani1998 AyushBherwani1998 requested review from a team as code owners June 24, 2025 12:52
Copy link

vercel bot commented Jun 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metamask-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2025 2:16am

@AyushBherwani1998 AyushBherwani1998 marked this pull request as draft June 24, 2025 12:53
chin-flags
chin-flags previously approved these changes Jun 24, 2025
Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Included a comment.

@bgravenorst
Copy link
Contributor

@AyushBherwani1998 I assume we want to create the new version after merging these updates? Let us know, and we can release the new version after these are merged.

@alexandratran
Copy link
Contributor

alexandratran commented Jun 25, 2025

@bgravenorst DevRel typically creates a separate PR to release a new version and add a version changelog. @AyushBherwani1998 Releasing a version is the same process as in the old docs, except you need to tag the plugin ID in the command: npm run docusaurus docs:version:gator 0.12.0.

@@ -101,6 +101,13 @@ delegator account to the delegate account.
This example passes an empty `caveats` array, which means the delegate can perform any action on the delegator's behalf.
We recommend [restricting the delegation](../how-to/create-delegation/restrict-delegation.md) by adding caveat enforcers.

:::warning Important

Before creating a delegation, ensure that the delegator account has

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be "Before redeeming a delegation..."

Additionally, it might be worthwhile including some guidance on how to deploy the account as part of the redemption (can encode the factory call in the useroperation that redeems the delegation 🎉 )

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if we should keep it before creating delegation, or redeeming the delegation? In case if it's done while redeeming the delegation, the delegate has to pay the gas fee.

Co-authored-by: Alexandra Carrillo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants