-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Delegation Toolkit] Update docs #2116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Included a comment.
@AyushBherwani1998 I assume we want to create the new version after merging these updates? Let us know, and we can release the new version after these are merged. |
@bgravenorst DevRel typically creates a separate PR to release a new version and add a version changelog. @AyushBherwani1998 Releasing a version is the same process as in the old docs, except you need to tag the plugin ID in the command: |
@@ -101,6 +101,13 @@ delegator account to the delegate account. | |||
This example passes an empty `caveats` array, which means the delegate can perform any action on the delegator's behalf. | |||
We recommend [restricting the delegation](../how-to/create-delegation/restrict-delegation.md) by adding caveat enforcers. | |||
|
|||
:::warning Important | |||
|
|||
Before creating a delegation, ensure that the delegator account has |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be "Before redeeming a delegation..."
Additionally, it might be worthwhile including some guidance on how to deploy the account as part of the redemption (can encode the factory call in the useroperation that redeems the delegation 🎉 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if we should keep it before creating delegation, or redeeming the delegation? In case if it's done while redeeming the delegation, the delegate has to pay the gas fee.
delegation-toolkit/how-to/create-smart-account/configure-accounts-signers.md
Outdated
Show resolved
Hide resolved
delegation-toolkit/how-to/create-smart-account/configure-accounts-signers.md
Outdated
Show resolved
Hide resolved
delegation-toolkit/how-to/create-smart-account/configure-accounts-signers.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexandra Carrillo <[email protected]>
Description
Update delegation toolkit docs to latest v0.12.0 release
Preview
Checklist
Complete this checklist before merging your PR: