-
Notifications
You must be signed in to change notification settings - Fork 5.5k
refactor: Unflatten selectors and convert to TypeScript #29014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Unflatten selectors and convert to TypeScript #29014
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
d47b4eb to
143f1a2
Compare
ba499fd to
7ad7c9a
Compare
metamask slice selectors and convert to TypeScriptmetamask slice selectors and convert to TypeScript (3/5)
7ad7c9a to
e17a049
Compare
3880292 to
66188c8
Compare
metamask slice selectors and convert to TypeScript (3/5)metamask slice (3/5)
e17a049 to
168e2b7
Compare
66188c8 to
dd75333
Compare
0971827 to
c557fee
Compare
f4ebdb6 to
63d8618
Compare
c557fee to
8384a85
Compare
4419d3e to
f8ca26b
Compare
8384a85 to
44dde0e
Compare
f8ca26b to
ebdd010
Compare
44dde0e to
cf9e3ae
Compare
14b4b24 to
062dcc8
Compare
cf9e3ae to
f854428
Compare
1add77c to
c47ed91
Compare
13db6b8 to
689dc40
Compare
3d79a33 to
89263ea
Compare
d656eaa to
7cab4c4
Compare
7cab4c4 to
55fc96e
Compare
metamask slice (3/5)metamask slice (3/6)
metamask slice (3/6)Force github to recognize renames part 2 Force github to recognize renames part 3
1852790 to
9c931d8
Compare
c47ed91 to
7af2f6a
Compare
|
This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions. |
|
This PR was closed because there has been no follow up activity in 7 days. Thank you for your contributions. |
Motivation
Converting selectors to TypeScript is strictly speaking out-of-scope for this epic, but I decided to undertake it for these reasons:
Description
metamaskslice.stateparameter to usecreate{,DeepEqual}Selectorinstead.statetype assignment with type dynamically derived from selector composition.Notes
ui/selectors,ui/ducks,ui/helpers/utils,shared/modules/selectors.ui/selectors(excluding type imports) from 5 to 33.Related issues
metamaskRedux slice #29600reselectto^5.1.1for heterogeneously-typed selectors support #29094Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist