fix(confirmations): allow cancel without gas pre-validation by vinistevam · Pull Request #43602 · MetaMask/metamask-extension

vinistevam · 2026-06-16T10:42:43Z

Description

The Cancel button on a pending transaction was disabled with a "Not enough gas" tooltip when the balance dipped below the cancel gas fee, while Speed Up stayed enabled — even though both use the same gas estimate. The asymmetry was confusing and the validation only lived on the button: the Cancel/Speed Up modal had no gas check and would let users submit straight into a failure toast.

This PR makes the modal the single source of truth:

Cancel and Speed Up buttons in the Activity list are always enabled, matching each other.
Inside the modal, when the balance can't cover the gas fee, the Confirm button is disabled and relabelled "Insufficient funds" (reusing insufficientFundsSend, no new translations).
Also drops dead transaction / detailsModal props from CancelButton and its call sites, made redundant by the fix.

Changelog

CHANGELOG entry: Fixed Cancel button being disabled by a "Not enough gas" check while Speed Up stayed enabled on pending transactions.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/CONF-1299

Manual testing steps

Run the extension and create a pending transaction (low gas
price, or local Anvil with mining paused).
Open the Activity list — both Cancel and Speed up are enabled.
Drain the account so the balance is below the cancel gas fee.
Cancel is still enabled; tapping it opens the modal with a
disabled Confirm button reading "Insufficient funds".
Top the account back up and reopen the modal — Confirm now
reads "Confirm" and submitting cancels the transaction.
Repeat step 3 with Speed up to confirm symmetric behaviour.

Screenshots/Recordings

Screencast.from.2026-06-16.11-25-10.webm

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…ion logic

github-actions · 2026-06-16T10:42:55Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

mm-token-exchange-service · 2026-06-16T10:43:11Z

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations (2 files, +78 -5)

📁 ui/
- 📁 pages/
  - 📁 confirmations/
    - 📁 cancel-speedup/
      - 📄 cancel-speedup.test.tsx +49 -2
      - 📄 cancel-speedup.tsx +29 -3

👨‍🔧 @MetaMask/core-extension-ux (6 files, +7 -12)

📁 ui/
- 📁 components/
  - 📁 app/
    - 📁 transaction-list-item/
      - 📄 smart-transaction-list-item.component.js +0 -1
      - 📄 transaction-list-item-pending-actions.tsx +0 -1
      - 📄 transaction-list-item.component.js +0 -1
      - 📄 transaction-list-item.component.test.js +7 -6
    - 📁 transaction-list-item-details/
      - 📄 transaction-list-item-details.component.js +0 -2
  - 📁 multichain/
    - 📁 activity-list-item/
      - 📄 activity-list-item.stories.js +0 -1

mm-token-exchange-service · 2026-06-16T11:13:19Z

Builds ready [f85905e]

⚠️ Make sure the build is safe before downloading and running this build.
- Please do not use these builds with accounts that contain significant real money.
- Beware the security risks of cache poisoning.
Webpack builds: chrome, firefox
Webpack builds (beta): chrome, firefox
Webpack builds (flask): chrome, firefox
Webpack builds (test): chrome, firefox
Webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
bundle analyzer: Bundle Analyzer
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts

Deprecated Browserify fallback builds

Browserify builds: chrome, firefox
Browserify builds (beta): chrome, firefox
Browserify builds (flask): chrome, firefox
Browserify builds (test): chrome, firefox
Browserify builds (test-flask): chrome, firefox

⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 9 warn · 🔴 0 fail)

Baseline (latest main): 7663b65 | Date: 6/16/2026 | Pipeline: 27611938722 | Baseline logs

Interaction Benchmarks · Samples: 5

Benchmark chrome-webpack firefox-webpack
loadNewAccount
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
confirmTx
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
bridgeUserActions
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
🟡 bridge_search_token

📈 Results compared to the previous 5 runs on main
↓ confirmTx/inp: -10%
↓ confirmTx/lcp: -11%
↓ bridgeUserActions/bridge_load_asset_picker: -15%
↓ bridgeUserActions/longTaskTotalDuration: -11%
↓ bridgeUserActions/tbt: -11%
↓ bridgeUserActions/inp: -21%
↑ loadNewAccount/load_new_account: +62%
↑ loadNewAccount/total: +62%
↑ loadNewAccount/inp: +67%
↓ loadNewAccount/fcp: -52%
↑ loadNewAccount/lcp: +1254%
↑ confirmTx/confirm_tx: +11%
↓ confirmTx/longTaskCount: -100%
↓ confirmTx/longTaskTotalDuration: -100%
↓ confirmTx/longTaskMaxDuration: -100%
↓ confirmTx/tbt: -100%
↑ confirmTx/total: +11%
↓ confirmTx/inp: -20%
↑ confirmTx/lcp: +1120%
↑ bridgeUserActions/bridge_load_page: +118%
↑ bridgeUserActions/bridge_load_asset_picker: +60%
↑ bridgeUserActions/bridge_search_token: +210%
↓ bridgeUserActions/longTaskCount: -100%
↓ bridgeUserActions/longTaskTotalDuration: -100%
↓ bridgeUserActions/longTaskMaxDuration: -100%
↓ bridgeUserActions/tbt: -100%
↑ bridgeUserActions/total: +182%
↓ bridgeUserActions/inp: -36%
↓ bridgeUserActions/fcp: -50%
↑ bridgeUserActions/lcp: +1139%

Startup Benchmarks · Samples: 100

Benchmark chrome-webpack firefox-webpack
startupStandardHome
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release] 🟡 [CI log] 🟡 [CI log]

📈 Results compared to the previous 5 runs on main
↑ startupPowerUserHome/domInteractive: +19%
↑ startupStandardHome/domInteractive: +14%
↓ startupStandardHome/inp: -29%
↑ startupStandardHome/fcp: +12%
↑ startupPowerUserHome/uiStartup: +13%
↑ startupPowerUserHome/load: +14%
↑ startupPowerUserHome/domContentLoaded: +14%
↑ startupPowerUserHome/domInteractive: +43%
↑ startupPowerUserHome/backgroundConnect: +68%
↑ startupPowerUserHome/firstReactRender: +16%
↑ startupPowerUserHome/loadScripts: +14%
↑ startupPowerUserHome/setupStore: +11%
↑ startupPowerUserHome/inp: +16%
↑ startupPowerUserHome/fcp: +41%
↑ startupPowerUserHome/lcp: +14%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🔴 startupPowerUserHome/INP: p75 536ms
🟡 startupPowerUserHome/INP: p75 208ms
🟡 startupPowerUserHome/LCP: p75 3.4s

User Journey Benchmarks · Samples: 5 · mock API

Benchmark chrome-webpack firefox-webpack
onboardingImportWallet
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release] 🟢 [CI log] 🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release] 🟡 [CI log] 🟡 [CI log]
solanaAssetDetails
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
importSrpHome
[Sentry log · main/release] 🟡 [CI log] 🟡 [CI log]
sendTransactions
[Sentry log · main/release] 🟡 [CI log] 🟡 [CI log]
swap
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]

📈 Results compared to the previous 5 runs on main
↓ onboardingImportWallet/srpButtonToSrpForm: -25%
↓ onboardingImportWallet/confirmSrpToPwForm: -28%
↓ onboardingImportWallet/pwFormToMetricsScreen: -28%
↓ onboardingImportWallet/metricsToWalletReadyScreen: -26%
↓ onboardingImportWallet/doneButtonToHomeScreen: -88%
↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -98%
↓ onboardingImportWallet/longTaskCount: -80%
↓ onboardingImportWallet/longTaskTotalDuration: -95%
↓ onboardingImportWallet/longTaskMaxDuration: -93%
↓ onboardingImportWallet/tbt: -100%
↓ onboardingImportWallet/total: -87%
↓ onboardingNewWallet/srpButtonToPwForm: -29%
↓ onboardingNewWallet/createPwToRecoveryScreen: -30%
↓ onboardingNewWallet/skipBackupToMetricsScreen: -29%
↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -33%
↓ onboardingNewWallet/doneButtonToAssetList: -94%
↓ onboardingNewWallet/longTaskCount: -100%
↓ onboardingNewWallet/longTaskTotalDuration: -100%
↓ onboardingNewWallet/longTaskMaxDuration: -100%
↓ onboardingNewWallet/tbt: -100%
↓ onboardingNewWallet/total: -81%
↓ solanaAssetDetails/assetClickToPriceChart: -29%
↓ solanaAssetDetails/longTaskCount: -100%
↓ solanaAssetDetails/longTaskTotalDuration: -100%
↓ solanaAssetDetails/longTaskMaxDuration: -100%
↓ solanaAssetDetails/tbt: -100%
↓ solanaAssetDetails/total: -29%
↑ solanaAssetDetails/inp: +19%
↓ solanaAssetDetails/cls: -89%
↓ importSrpHome/loginToHomeScreen: -15%
↓ importSrpHome/homeAfterImportWithNewWallet: -38%
↓ importSrpHome/longTaskCount: -17%
↓ importSrpHome/longTaskTotalDuration: -24%
↓ importSrpHome/longTaskMaxDuration: -25%
↓ importSrpHome/tbt: -25%
↓ importSrpHome/total: -32%
↓ importSrpHome/inp: -33%
↑ sendTransactions/openSendPageFromHome: +16%
↑ sendTransactions/selectTokenToSendFormLoaded: +18%
↑ sendTransactions/tbt: +22%
↓ sendTransactions/cls: -69%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 assetDetails/FCP: p75 2.0s
🟡 importSrpHome/FCP: p75 1.8s
🟡 sendTransactions/INP: p75 224ms
🟡 assetDetails/FCP: p75 1.8s
🟡 importSrpHome/FCP: p75 1.9s
🟡 sendTransactions/FCP: p75 1.8s

Dapp Page Load Benchmarks · Samples: 100

Benchmark chrome-webpack
dappPageLoad
[Sentry log · main/release] 🟢 [CI log]

Bundle size diffs [🚀 Bundle size reduced!]

background: -555 Bytes (-0.01%)
ui: -3.08 KiB (-0.03%)
common: -13.82 KiB (-0.1%)

mm-token-exchange-service · 2026-06-16T13:57:59Z

Builds ready [fca24d2] [reused from 6d36bdf]

⚠️ Make sure the build is safe before downloading and running this build.
- Please do not use these builds with accounts that contain significant real money.
- Beware the security risks of cache poisoning.
Webpack builds: chrome, firefox
Webpack builds (beta): chrome, firefox
Webpack builds (flask): chrome, firefox
Webpack builds (test): chrome, firefox
Webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
bundle analyzer: Bundle Analyzer
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts

Deprecated Browserify fallback builds

Browserify builds: chrome, firefox
Browserify builds (beta): chrome, firefox
Browserify builds (flask): chrome, firefox
Browserify builds (test): chrome, firefox
Browserify builds (test-flask): chrome, firefox

⚡ Performance Benchmarks (Total: 🟢 13 pass · 🟡 7 warn · 🔴 0 fail)

Baseline (latest main): dd70ee8 | Date: 6/16/2026 | Pipeline: 27621214807 | Baseline logs

Interaction Benchmarks · Samples: 5

Benchmark chrome-webpack firefox-webpack
loadNewAccount
[Sentry log · main/release] 🟡 [CI log] 🟢 [CI log]
confirmTx
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
bridgeUserActions
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]

📈 Results compared to the previous 5 runs on main
↓ loadNewAccount/load_new_account: -16%
↓ loadNewAccount/total: -16%
↑ loadNewAccount/inp: +60%
↑ confirmTx/inp: +32%
↓ bridgeUserActions/bridge_load_asset_picker: -16%
↓ bridgeUserActions/tbt: -11%
↓ bridgeUserActions/inp: -21%
↑ loadNewAccount/load_new_account: +30%
↑ loadNewAccount/total: +30%
↑ loadNewAccount/lcp: +1113%
↑ confirmTx/confirm_tx: +12%
↓ confirmTx/longTaskCount: -100%
↓ confirmTx/longTaskTotalDuration: -100%
↓ confirmTx/longTaskMaxDuration: -100%
↓ confirmTx/tbt: -100%
↑ confirmTx/total: +12%
↑ confirmTx/lcp: +1196%
↑ bridgeUserActions/bridge_load_page: +73%
↑ bridgeUserActions/bridge_load_asset_picker: +95%
↓ bridgeUserActions/longTaskCount: -100%
↓ bridgeUserActions/longTaskTotalDuration: -100%
↓ bridgeUserActions/longTaskMaxDuration: -100%
↓ bridgeUserActions/tbt: -100%
↑ bridgeUserActions/total: +22%
↓ bridgeUserActions/inp: -12%
↑ bridgeUserActions/lcp: +1152%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 loadNewAccount/FCP: p75 1.9s

Startup Benchmarks · Samples: 100

⚠️ Missing data: firefox/webpack/startupPowerUserHome

Benchmark chrome-webpack firefox-webpack
startupStandardHome
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release] 🟡 [CI log] –

📈 Results compared to the previous 5 runs on main
↓ startupStandardHome/cls: -100%
↑ startupStandardHome/initialActions: +11%
↑ startupStandardHome/setupStore: +14%
↓ startupStandardHome/inp: -29%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🔴 startupPowerUserHome/INP: p75 568ms

User Journey Benchmarks · Samples: 5 · mock API

⚠️ Missing data: chrome/webpack/userJourneyTransactions, firefox/webpack/userJourneyTransactions

Benchmark chrome-webpack firefox-webpack
onboardingImportWallet
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release] 🟢 [CI log] 🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release] 🟢 [CI log] 🟡 [CI log]
solanaAssetDetails
[Sentry log · main/release] 🟢 [CI log] 🟡 [CI log]
importSrpHome
[Sentry log · main/release] 🟡 [CI log] 🟡 [CI log]

📈 Results compared to the previous 5 runs on main
↓ onboardingImportWallet/doneButtonToHomeScreen: -88%
↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -97%
↓ onboardingImportWallet/longTaskCount: -77%
↓ onboardingImportWallet/longTaskTotalDuration: -94%
↓ onboardingImportWallet/longTaskMaxDuration: -91%
↓ onboardingImportWallet/tbt: -98%
↓ onboardingImportWallet/total: -88%
↓ onboardingNewWallet/doneButtonToAssetList: -28%
↓ onboardingNewWallet/longTaskCount: -55%
↓ onboardingNewWallet/longTaskTotalDuration: -31%
↓ onboardingNewWallet/tbt: -29%
↓ onboardingNewWallet/total: -25%
↓ solanaAssetDetails/assetClickToPriceChart: -74%
↓ solanaAssetDetails/longTaskCount: -100%
↓ solanaAssetDetails/longTaskTotalDuration: -100%
↓ solanaAssetDetails/longTaskMaxDuration: -100%
↓ solanaAssetDetails/tbt: -100%
↓ solanaAssetDetails/total: -74%
↓ solanaAssetDetails/fcp: -20%
↓ solanaAssetDetails/lcp: -10%
↓ solanaAssetDetails/cls: -91%
↓ importSrpHome/loginToHomeScreen: -17%
↑ importSrpHome/openAccountMenuAfterLogin: +123%
↓ importSrpHome/homeAfterImportWithNewWallet: -39%
↓ importSrpHome/longTaskCount: -17%
↓ importSrpHome/longTaskTotalDuration: -25%
↓ importSrpHome/tbt: -21%
↓ importSrpHome/total: -33%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 importSrpHome/INP: p75 232ms
🟡 assetDetails/FCP: p75 1.9s
🟡 solanaAssetDetails/FCP: p75 1.9s
🟡 importSrpHome/FCP: p75 1.9s

Dapp Page Load Benchmarks · Samples: 100

Benchmark chrome-webpack
dappPageLoad
[Sentry log · main/release] 🟢 [CI log]

Bundle size diffs [🚀 Bundle size reduced!]

background: 313 Bytes (0%)
ui: -1.3 KiB (-0.01%)
common: 80 Bytes (0%)

mm-token-exchange-service · 2026-06-17T04:34:11Z

Builds ready [5f5a9cc]

⚠️ Make sure the build is safe before downloading and running this build.
- Please do not use these builds with accounts that contain significant real money.
- Beware the security risks of cache poisoning.
Webpack builds: chrome, firefox
Webpack builds (beta): chrome, firefox
Webpack builds (flask): chrome, firefox
Webpack builds (test): chrome, firefox
Webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
bundle analyzer: Bundle Analyzer
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts

Deprecated Browserify fallback builds

Browserify builds: chrome, firefox
Browserify builds (beta): chrome, firefox
Browserify builds (flask): chrome, firefox
Browserify builds (test): chrome, firefox
Browserify builds (test-flask): chrome, firefox

⚡ Performance Benchmarks (Total: 🟢 15 pass · 🟡 10 warn · 🔴 0 fail)

Baseline (latest main): bb45f97 | Date: 6/17/2026 | Pipeline: 27664998043 | Baseline logs

Interaction Benchmarks · Samples: 5

Benchmark chrome-webpack firefox-webpack
loadNewAccount
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
confirmTx
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
bridgeUserActions
[Sentry log · main/release] 🟢 [CI log] 🟡 [CI log]

📈 Results compared to the previous 5 runs on main
↓ loadNewAccount/inp: -18%
↑ loadNewAccount/lcp: +20%
↑ confirmTx/tbt: +13%
↓ confirmTx/inp: -19%
↓ bridgeUserActions/longTaskCount: -17%
↓ bridgeUserActions/inp: -29%
↑ bridgeUserActions/cls: +25%
↑ loadNewAccount/load_new_account: +62%
↑ loadNewAccount/total: +62%
↓ loadNewAccount/inp: -18%
↑ loadNewAccount/lcp: +1141%
↓ confirmTx/longTaskCount: -100%
↓ confirmTx/longTaskTotalDuration: -100%
↓ confirmTx/longTaskMaxDuration: -100%
↓ confirmTx/tbt: -100%
↓ confirmTx/inp: -27%
↓ confirmTx/fcp: -49%
↑ confirmTx/lcp: +1189%
↑ bridgeUserActions/bridge_load_page: +85%
↑ bridgeUserActions/bridge_load_asset_picker: +28%
↓ bridgeUserActions/longTaskCount: -100%
↓ bridgeUserActions/longTaskTotalDuration: -100%
↓ bridgeUserActions/longTaskMaxDuration: -100%
↓ bridgeUserActions/tbt: -100%
↑ bridgeUserActions/total: +193%
↓ bridgeUserActions/inp: -21%
↑ bridgeUserActions/lcp: +1084%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 bridgeUserActions/FCP: p75 1.8s

Startup Benchmarks · Samples: 100

Benchmark chrome-webpack firefox-webpack
startupStandardHome
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release] 🟡 [CI log] 🟡 [CI log]

📈 Results compared to the previous 5 runs on main
↓ startupPowerUserHome/numNetworkReqs: -11%
↓ startupStandardHome/domInteractive: -18%
↓ startupStandardHome/inp: -23%
↓ startupStandardHome/fcp: -19%
↓ startupPowerUserHome/setupStore: -31%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 startupPowerUserHome/INP: p75 480ms
🟡 startupPowerUserHome/LCP: p75 3.0s

User Journey Benchmarks · Samples: 5 · mock API

Benchmark chrome-webpack firefox-webpack
onboardingImportWallet
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release] 🟢 [CI log] 🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release] 🟡 [CI log] 🟡 [CI log]
solanaAssetDetails
[Sentry log · main/release] 🟢 [CI log] 🟡 [CI log]
importSrpHome
[Sentry log · main/release] 🟢 [CI log] 🟡 [CI log]
sendTransactions
[Sentry log · main/release] 🟡 [CI log] 🟡 [CI log]
swap
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]

📈 Results compared to the previous 5 runs on main
↑ onboardingImportWallet/confirmSrpToPwForm: +13%
↑ onboardingImportWallet/pwFormToMetricsScreen: +11%
↓ onboardingImportWallet/doneButtonToHomeScreen: -89%
↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -49%
↓ onboardingImportWallet/longTaskCount: -75%
↓ onboardingImportWallet/longTaskTotalDuration: -93%
↓ onboardingImportWallet/longTaskMaxDuration: -91%
↓ onboardingImportWallet/tbt: -98%
↓ onboardingImportWallet/total: -86%
↓ onboardingNewWallet/srpButtonToPwForm: -26%
↓ onboardingNewWallet/createPwToRecoveryScreen: -23%
↓ onboardingNewWallet/skipBackupToMetricsScreen: -23%
↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -18%
↓ onboardingNewWallet/doneButtonToAssetList: -62%
↓ onboardingNewWallet/longTaskCount: -62%
↓ onboardingNewWallet/longTaskTotalDuration: -70%
↓ onboardingNewWallet/longTaskMaxDuration: -42%
↓ onboardingNewWallet/tbt: -83%
↓ onboardingNewWallet/total: -56%
↓ solanaAssetDetails/assetClickToPriceChart: -34%
↓ solanaAssetDetails/longTaskCount: -100%
↓ solanaAssetDetails/total: -34%
↑ solanaAssetDetails/inp: +17%
↓ solanaAssetDetails/cls: -84%
↓ importSrpHome/loginToHomeScreen: -24%
↑ importSrpHome/openAccountMenuAfterLogin: +11%
↓ importSrpHome/homeAfterImportWithNewWallet: -41%
↓ importSrpHome/longTaskCount: -26%
↓ importSrpHome/longTaskTotalDuration: -36%
↓ importSrpHome/longTaskMaxDuration: -28%
↓ importSrpHome/tbt: -41%
↓ importSrpHome/total: -36%
↓ importSrpHome/inp: -23%
↑ sendTransactions/openSendPageFromHome: +53%
↑ sendTransactions/selectTokenToSendFormLoaded: +76%
↓ sendTransactions/longTaskMaxDuration: -13%
↑ sendTransactions/inp: +12%
↓ sendTransactions/cls: -79%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 assetDetails/FCP: p75 2.0s
🟡 sendTransactions/INP: p75 248ms
🟡 sendTransactions/FCP: p75 1.9s
🟡 assetDetails/FCP: p75 1.8s
🟡 solanaAssetDetails/FCP: p75 1.8s
🟡 importSrpHome/FCP: p75 1.9s
🟡 sendTransactions/FCP: p75 1.9s

Dapp Page Load Benchmarks · Samples: 100

Benchmark chrome-webpack
dappPageLoad
[Sentry log · main/release] 🟢 [CI log]

Bundle size diffs [🚀 Bundle size reduced!]

background: 58 Bytes (0%)
ui: -2.92 KiB (-0.03%)
common: -20 Bytes (0%)

mm-token-exchange-service · 2026-06-17T05:11:57Z

Builds ready [1bf0d47]

⚠️ Make sure the build is safe before downloading and running this build.
- Please do not use these builds with accounts that contain significant real money.
- Beware the security risks of cache poisoning.
Webpack builds: chrome, firefox
Webpack builds (beta): chrome, firefox
Webpack builds (flask): chrome, firefox
Webpack builds (test): chrome, firefox
Webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
bundle analyzer: Bundle Analyzer
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts

Deprecated Browserify fallback builds

Browserify builds: chrome, firefox
Browserify builds (beta): chrome, firefox
Browserify builds (flask): chrome, firefox
Browserify builds (test): chrome, firefox
Browserify builds (test-flask): chrome, firefox

⚡ Performance Benchmarks (Total: 🟢 15 pass · 🟡 9 warn · 🔴 1 fail)

Baseline (latest main): e27350d | Date: 6/17/2026 | Pipeline: 27666254208 | Baseline logs

Metrics chrome-webpack firefox-webpack
loadNewAccount
[Sentry log · main/release] 🟢 [CI log] 🔴 load_new_account(p95) [CI log]

Regressions (🔴 1 failure)

loadNewAccount [Sentry log · main/release] · firefox-webpack — load_new_account(p75) [CI log]

Interaction Benchmarks · Samples: 5 🔴 1

Benchmark chrome-webpack firefox-webpack
loadNewAccount
[Sentry log · main/release] 🟢 [CI log] 🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
bridgeUserActions
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
🟡 bridge_search_token

📈 Results compared to the previous 5 runs on main
↑ loadNewAccount/inp: +45%
↓ confirmTx/inp: -19%
↑ bridgeUserActions/bridge_load_page: +24%
↓ bridgeUserActions/inp: -14%
↑ bridgeUserActions/cls: +25%
↑ loadNewAccount/load_new_account: +636%
↑ loadNewAccount/total: +636%
↓ loadNewAccount/fcp: -67%
↑ loadNewAccount/lcp: +1345%
↓ confirmTx/longTaskCount: -100%
↓ confirmTx/longTaskTotalDuration: -100%
↓ confirmTx/longTaskMaxDuration: -100%
↓ confirmTx/tbt: -100%
↑ confirmTx/inp: +77%
↓ confirmTx/fcp: -63%
↑ confirmTx/lcp: +1142%
↑ bridgeUserActions/bridge_load_page: +24%
↑ bridgeUserActions/bridge_load_asset_picker: +18%
↑ bridgeUserActions/bridge_search_token: +203%
↓ bridgeUserActions/longTaskCount: -100%
↓ bridgeUserActions/longTaskTotalDuration: -100%
↓ bridgeUserActions/longTaskMaxDuration: -100%
↓ bridgeUserActions/tbt: -100%
↑ bridgeUserActions/total: +160%
↓ bridgeUserActions/inp: -22%
↑ bridgeUserActions/lcp: +1079%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 loadNewAccount/LCP: p75 2.5s

Startup Benchmarks · Samples: 100

Benchmark chrome-webpack firefox-webpack
startupStandardHome
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release] 🟡 [CI log] 🟡 [CI log]

📈 Results compared to the previous 5 runs on main
↑ startupPowerUserHome/numNetworkReqs: +13%
↓ startupStandardHome/domInteractive: -26%
↓ startupStandardHome/inp: -23%
↓ startupStandardHome/fcp: -25%
↑ startupPowerUserHome/domInteractive: +16%
↓ startupPowerUserHome/backgroundConnect: -47%
↓ startupPowerUserHome/setupStore: -26%
↑ startupPowerUserHome/fcp: +16%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 startupPowerUserHome/INP: p75 440ms
🟡 startupPowerUserHome/LCP: p75 2.9s

User Journey Benchmarks · Samples: 5 · mock API

Benchmark chrome-webpack firefox-webpack
onboardingImportWallet
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release] 🟢 [CI log] 🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release] 🟡 [CI log] 🟡 [CI log]
solanaAssetDetails
[Sentry log · main/release] 🟢 [CI log] 🟡 [CI log]
importSrpHome
[Sentry log · main/release] 🟡 [CI log] 🟢 [CI log]
sendTransactions
[Sentry log · main/release] 🟡 [CI log] 🟡 [CI log]
swap
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]

📈 Results compared to the previous 5 runs on main
↓ onboardingImportWallet/doneButtonToHomeScreen: -90%
↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -67%
↓ onboardingImportWallet/longTaskCount: -76%
↓ onboardingImportWallet/longTaskTotalDuration: -93%
↓ onboardingImportWallet/longTaskMaxDuration: -86%
↓ onboardingImportWallet/tbt: -94%
↓ onboardingImportWallet/total: -88%
↑ onboardingNewWallet/createPwToRecoveryScreen: +12%
↓ onboardingNewWallet/doneButtonToAssetList: -30%
↓ onboardingNewWallet/longTaskCount: -58%
↓ onboardingNewWallet/longTaskTotalDuration: -62%
↓ onboardingNewWallet/longTaskMaxDuration: -30%
↓ onboardingNewWallet/tbt: -64%
↓ onboardingNewWallet/total: -26%
↑ solanaAssetDetails/assetClickToPriceChart: +258%
↑ solanaAssetDetails/longTaskCount: +400%
↑ solanaAssetDetails/total: +258%
↓ solanaAssetDetails/lcp: -10%
↓ solanaAssetDetails/cls: -73%
↓ importSrpHome/loginToHomeScreen: -17%
↑ importSrpHome/openAccountMenuAfterLogin: +17%
↓ importSrpHome/homeAfterImportWithNewWallet: -39%
↓ importSrpHome/longTaskCount: -33%
↓ importSrpHome/longTaskTotalDuration: -34%
↓ importSrpHome/tbt: -26%
↓ importSrpHome/total: -30%
↑ importSrpHome/fcp: +16%
↑ importSrpHome/lcp: +16%
↑ sendTransactions/openSendPageFromHome: +75%
↑ sendTransactions/selectTokenToSendFormLoaded: +24%
↑ sendTransactions/longTaskCount: +11%
↑ sendTransactions/longTaskTotalDuration: +13%
↑ sendTransactions/tbt: +13%
↓ sendTransactions/inp: -10%
↑ sendTransactions/lcp: +13%
↓ sendTransactions/cls: -39%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 assetDetails/FCP: p75 1.8s
🟡 importSrpHome/INP: p75 256ms
🟡 importSrpHome/FCP: p75 2.0s
🟡 sendTransactions/INP: p75 208ms
🟡 assetDetails/FCP: p75 1.9s
🟡 solanaAssetDetails/FCP: p75 2.0s
🟡 sendTransactions/FCP: p75 1.9s

Dapp Page Load Benchmarks · Samples: 100

Benchmark chrome-webpack
dappPageLoad
[Sentry log · main/release] 🟢 [CI log]

Bundle size diffs [🚀 Bundle size reduced!]

background: 58 Bytes (0%)
ui: -2.92 KiB (-0.03%)
common: -20 Bytes (0%)

mm-token-exchange-service · 2026-06-17T09:56:36Z

Builds ready [004778e]

⚠️ Make sure the build is safe before downloading and running this build.
- Please do not use these builds with accounts that contain significant real money.
- Beware the security risks of cache poisoning.
Webpack builds: chrome, firefox
Webpack builds (beta): chrome, firefox
Webpack builds (flask): chrome, firefox
Webpack builds (test): chrome, firefox
Webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
bundle analyzer: Bundle Analyzer
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts

Deprecated Browserify fallback builds

Browserify builds: chrome, firefox
Browserify builds (beta): chrome, firefox
Browserify builds (flask): chrome, firefox
Browserify builds (test): chrome, firefox
Browserify builds (test-flask): chrome, firefox

⚡ Performance Benchmarks (Total: 🟢 15 pass · 🟡 10 warn · 🔴 0 fail)

Baseline (latest main): 735181a | Date: 6/17/2026 | Pipeline: 27679205625 | Baseline logs

Interaction Benchmarks · Samples: 5

Benchmark chrome-webpack firefox-webpack
loadNewAccount
[Sentry log · main/release] 🟢 [CI log] 🟡 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
bridgeUserActions
[Sentry log · main/release] 🟢 [CI log] 🟡 [CI log]
🟡 bridge_search_token

📈 Results compared to the previous 5 runs on main
↓ loadNewAccount/load_new_account: -12%
↓ loadNewAccount/total: -12%
↓ confirmTx/inp: -17%
↑ bridgeUserActions/bridge_load_asset_picker: +12%
↑ bridgeUserActions/inp: +16%
↑ bridgeUserActions/cls: +25%
↑ loadNewAccount/load_new_account: +547%
↑ loadNewAccount/total: +547%
↓ loadNewAccount/inp: -25%
↑ loadNewAccount/lcp: +1165%
↑ confirmTx/confirm_tx: +12%
↓ confirmTx/longTaskCount: -100%
↓ confirmTx/longTaskTotalDuration: -100%
↓ confirmTx/longTaskMaxDuration: -100%
↓ confirmTx/tbt: -100%
↑ confirmTx/total: +12%
↓ confirmTx/inp: -32%
↓ confirmTx/fcp: -39%
↑ confirmTx/lcp: +1153%
↑ bridgeUserActions/bridge_load_page: +90%
↑ bridgeUserActions/bridge_load_asset_picker: +99%
↑ bridgeUserActions/bridge_search_token: +216%
↓ bridgeUserActions/longTaskCount: -100%
↓ bridgeUserActions/longTaskTotalDuration: -100%
↓ bridgeUserActions/longTaskMaxDuration: -100%
↓ bridgeUserActions/tbt: -100%
↑ bridgeUserActions/total: +208%
↓ bridgeUserActions/inp: -11%
↑ bridgeUserActions/lcp: +1139%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 loadNewAccount/FCP: p75 1.8s
🟡 bridgeUserActions/FCP: p75 1.9s

Startup Benchmarks · Samples: 100

Benchmark chrome-webpack firefox-webpack
startupStandardHome
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release] 🟡 [CI log] 🟡 [CI log]

📈 Results compared to the previous 5 runs on main
↓ startupPowerUserHome/setupStore: -11%
↓ startupPowerUserHome/numNetworkReqs: -14%
↓ startupStandardHome/domInteractive: -20%
↓ startupStandardHome/fcp: -23%
↓ startupPowerUserHome/domInteractive: -19%
↓ startupPowerUserHome/backgroundConnect: -35%
↓ startupPowerUserHome/setupStore: -41%
↓ startupPowerUserHome/fcp: -12%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 startupPowerUserHome/INP: p75 448ms
🟡 startupPowerUserHome/LCP: p75 2.6s

User Journey Benchmarks · Samples: 5 · mock API

Benchmark chrome-webpack firefox-webpack
onboardingImportWallet
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release] 🟢 [CI log] 🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release] 🟢 [CI log] 🟡 [CI log]
solanaAssetDetails
[Sentry log · main/release] 🟢 [CI log] 🟡 [CI log]
importSrpHome
[Sentry log · main/release] 🟢 [CI log] 🟡 [CI log]
sendTransactions
[Sentry log · main/release] 🟡 [CI log] 🟡 [CI log]
swap
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]

📈 Results compared to the previous 5 runs on main
↓ onboardingImportWallet/metricsToWalletReadyScreen: -20%
↓ onboardingImportWallet/doneButtonToHomeScreen: -89%
↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -98%
↓ onboardingImportWallet/longTaskCount: -75%
↓ onboardingImportWallet/longTaskTotalDuration: -94%
↓ onboardingImportWallet/longTaskMaxDuration: -91%
↓ onboardingImportWallet/tbt: -99%
↓ onboardingImportWallet/total: -89%
↓ onboardingNewWallet/doneButtonToAssetList: -28%
↓ onboardingNewWallet/longTaskCount: -55%
↓ onboardingNewWallet/longTaskTotalDuration: -41%
↓ onboardingNewWallet/tbt: -24%
↓ onboardingNewWallet/total: -24%
↓ solanaAssetDetails/assetClickToPriceChart: -47%
↓ solanaAssetDetails/longTaskCount: -100%
↓ solanaAssetDetails/longTaskTotalDuration: -100%
↓ solanaAssetDetails/longTaskMaxDuration: -100%
↓ solanaAssetDetails/tbt: -100%
↓ solanaAssetDetails/total: -47%
↓ solanaAssetDetails/cls: -84%
↓ importSrpHome/loginToHomeScreen: -16%
↑ importSrpHome/openAccountMenuAfterLogin: +115%
↓ importSrpHome/homeAfterImportWithNewWallet: -40%
↓ importSrpHome/longTaskCount: -25%
↓ importSrpHome/longTaskTotalDuration: -36%
↓ importSrpHome/longTaskMaxDuration: -17%
↓ importSrpHome/tbt: -40%
↓ importSrpHome/total: -33%
↓ importSrpHome/inp: -35%
↓ importSrpHome/lcp: -16%
↓ sendTransactions/openSendPageFromHome: -17%
↑ sendTransactions/selectTokenToSendFormLoaded: +52%
↑ sendTransactions/longTaskCount: +11%
↑ sendTransactions/longTaskTotalDuration: +15%
↑ sendTransactions/tbt: +20%
↑ sendTransactions/fcp: +15%
↑ sendTransactions/lcp: +18%
↓ sendTransactions/cls: -56%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 sendTransactions/INP: p75 208ms
🟡 sendTransactions/FCP: p75 2.0s
🟡 assetDetails/FCP: p75 1.9s
🟡 solanaAssetDetails/FCP: p75 1.8s
🟡 importSrpHome/FCP: p75 1.9s
🟡 sendTransactions/FCP: p75 1.8s

Dapp Page Load Benchmarks · Samples: 100

Benchmark chrome-webpack
dappPageLoad
[Sentry log · main/release] 🟢 [CI log]

Bundle size diffs [🚀 Bundle size reduced!]

background: 58 Bytes (0%)
ui: -2.92 KiB (-0.03%)
common: -20 Bytes (0%)

refactor: simplify component by removing unused props and gas validat…

f85905e

…ion logic

vinistevam added the team-confirmations Push issues to confirmations team label Jun 16, 2026

vinistevam temporarily deployed to pr-comment June 16, 2026 10:42 — with GitHub Actions Inactive

github-actions Bot added the size-M label Jun 16, 2026

vinistevam temporarily deployed to pr-comment June 16, 2026 11:12 — with GitHub Actions Inactive

vinistevam added 2 commits June 16, 2026 13:47

Merge branch 'main' into vs/fix-cancel-button-gas-validation

9e08599

fix ci

6d36bdf

vinistevam temporarily deployed to pr-comment June 16, 2026 13:08 — with GitHub Actions Inactive

Merge branch 'main' into vs/fix-cancel-button-gas-validation

fca24d2

vinistevam marked this pull request as ready for review June 16, 2026 13:31

vinistevam requested review from a team as code owners June 16, 2026 13:31

vinistevam had a problem deploying to pr-comment June 16, 2026 13:31 — with GitHub Actions Error

vinistevam temporarily deployed to pr-comment June 16, 2026 13:31 — with GitHub Actions Inactive

github-actions Bot added the risk:low label Jun 16, 2026

vinistevam temporarily deployed to pr-comment June 16, 2026 13:56 — with GitHub Actions Inactive

Merge branch 'main' into vs/fix-cancel-button-gas-validation

5f5a9cc

vinistevam temporarily deployed to pr-comment June 17, 2026 04:04 — with GitHub Actions Inactive

vinistevam temporarily deployed to pr-comment June 17, 2026 04:33 — with GitHub Actions Inactive

Merge branch 'main' into vs/fix-cancel-button-gas-validation

1bf0d47

vinistevam temporarily deployed to pr-comment June 17, 2026 04:41 — with GitHub Actions Inactive

vinistevam temporarily deployed to pr-comment June 17, 2026 05:11 — with GitHub Actions Inactive

Merge branch 'main' into vs/fix-cancel-button-gas-validation

004778e

vinistevam temporarily deployed to pr-comment June 17, 2026 09:26 — with GitHub Actions Inactive

vinistevam temporarily deployed to pr-comment June 17, 2026 09:55 — with GitHub Actions Inactive

matthewwalsh0 requested review from OGPoyraz and pedronfigueiredo June 17, 2026 10:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(confirmations): allow cancel without gas pre-validation#43602

fix(confirmations): allow cancel without gas pre-validation#43602
vinistevam wants to merge 7 commits into
mainfrom
vs/fix-cancel-button-gas-validation

vinistevam commented Jun 16, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 16, 2026

Uh oh!

mm-token-exchange-service Bot commented Jun 16, 2026

Uh oh!

mm-token-exchange-service Bot commented Jun 16, 2026

Uh oh!

mm-token-exchange-service Bot commented Jun 16, 2026

Uh oh!

mm-token-exchange-service Bot commented Jun 17, 2026

Uh oh!

mm-token-exchange-service Bot commented Jun 17, 2026

Uh oh!

mm-token-exchange-service Bot commented Jun 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

vinistevam commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Jun 16, 2026

Uh oh!

mm-token-exchange-service Bot commented Jun 16, 2026

✨ Files requiring CODEOWNER review ✨

Uh oh!

mm-token-exchange-service Bot commented Jun 16, 2026

Uh oh!

mm-token-exchange-service Bot commented Jun 16, 2026

Uh oh!

mm-token-exchange-service Bot commented Jun 17, 2026

Uh oh!

mm-token-exchange-service Bot commented Jun 17, 2026

Uh oh!

mm-token-exchange-service Bot commented Jun 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vinistevam commented Jun 16, 2026 •

edited

Loading