feat: adds a new fixture to disable STX

[christopherferreira9]

Description

• Adds a new fixture to disable STX to avoid extra steps in some E2E
• Removes try catch that were preventing tests from failing fast
• Migrates part of the swap related files to the new framework

Extra

Improvements on withFixtures under framework:

• extended to allow providing a mock server instance instead of letting the helper create one
• extended to allow providing an endTestfn to be executed after the test finishes and before the cleanup happens. Specially useful when we need to grab MetaMetrics events.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 791b1a3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/29ec5326-b38d-473b-b2f5-726f8520a862

Note

• You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 41c2237
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/57820dae-aa6d-48a4-acfb-5fb81e00e778

Note

• You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 273b7b8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a87121a2-a932-4fc3-8a3f-0cf391f7936c

Note

• You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: c34ae67
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bc7204ad-f12b-4a7c-903a-feecb19e51de

Note

• This comment will auto-update when build completes
• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[cursor]

Bug: API Contract Violation: Return Type Change

The generateApprovedTokenActivityLabel method's return type changed from a RegExp object to a string. This breaks the API contract, as callers may expect a RegExp for pattern matching, leading to runtime errors.

e2e/pages/Transactions/ActivitiesView.ts#L63-L68

metamask-mobile/e2e/pages/Transactions/ActivitiesView.ts

Lines 63 to 68 in 396a5bc

	generateApprovedTokenActivityLabel(sourceToken: string): string {
	let title = ActivitiesViewSelectorsText.APPROVE;
	title = title.replace('{{sourceToken}}', sourceToken);
	title = title.replace('{{upTo}}', '.*');
	return `^${title}`;

Fix in Cursor • Fix in Web

---

Bug: Mock Server Cleanup Affects External Instances

The withFixtures function prematurely stops externally provided mock server instances (mockServerInstance). This occurs because the cleanup logic's condition changed from if (testSpecificMock) to if (mockServer), causing stopMockServer to be called on all mock server instances, regardless of whether they were created internally or passed in externally. This interferes with externally managed mock servers, potentially breaking tests that intend to reuse them.

e2e/framework/fixtures/FixtureHelper.ts#L460-L463

metamask-mobile/e2e/framework/fixtures/FixtureHelper.ts

Lines 460 to 463 in 396a5bc

	if (mockServer) {
	await stopMockServer(mockServer);
	}

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[christopherferreira9]

Added No E2E Needed as the tests had passed before and all commits after that were just cleaning logs and fixing prettier + linting.

[davibroc]

LGTM