-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix: Truncate URL appropriately on iOS #17924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
smilingkylan
wants to merge
19
commits into
main
Choose a base branch
from
kylan/fix/webview-url-truncate
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+334
−30
Open
Changes from 15 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
88b4384
Fix TS error in BrowserUrlBar
smilingkylan 26e86b2
Update BrowserUrlBar snapshot
smilingkylan fa9e451
Fix minor formatting issue with BrowserUrlBar imports
smilingkylan 84ffd2d
Fix TS issue with BrowserUrlBar unit test
smilingkylan d88e7a8
Prettier format BrowserUrlBar unit test imports
smilingkylan f128fe6
Merge branch 'main' into kylan/fix/webview-url-truncate
smilingkylan 8829b2e
Merge branch 'main' into kylan/fix/webview-url-truncate
smilingkylan 75b2d7d
WIP
smilingkylan 938c12b
Use nativeProps for BrowserUrlBar
smilingkylan 08093cb
Adjust BrowserUrlBar unit tests
smilingkylan ae5304a
Add activeUrl fallback for BrowserUrlBar input value
smilingkylan a379731
Update snapshot
smilingkylan 87c18c7
Remove unnecessary conditional
smilingkylan eeb7990
Conditionally apply style for BrowserUrlBar button / text
smilingkylan f275c65
Adjust styling for BrowserUrlBar text button
smilingkylan 1700150
Merge branch 'main' into kylan/fix/webview-url-truncate
joaoloureirop f13349e
Merge branch 'main' into kylan/fix/webview-url-truncate
joaoloureirop 37f4c71
text prop runtime check
joaoloureirop a012f6e
explicit result
joaoloureirop File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.