-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix: cp-7.56.0 Add launch tests to performance suite #19941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
if (await closeButton.isVisible({ timeout })) { | ||
await closeButton.tap(); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Modal Dismissal Functions Fail Gracefully
The dismissGTMModal
and dismissMultichainAccountsIntroModal
functions can throw an unhandled exception. This occurs because AppwrightSelectors.getElementByText
and getElementByID
throw an error if the target modal isn't found within the timeout, preventing graceful handling of its absence.
|
Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist