Skip to content

Conversation

javiergarciavera
Copy link
Contributor

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Sep 17, 2025
cursor[bot]

This comment was marked as outdated.

cortisiko
cortisiko previously approved these changes Sep 17, 2025
@cortisiko cortisiko changed the title Mmqa 968 fix perf tests clean test: Add launch tests to performance suite Sep 17, 2025
@cortisiko cortisiko added No E2E Smoke Needed If the PR does not need E2E smoke test run no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed no changelog required No changelog entry is required for this change labels Sep 17, 2025
cursor[bot]

This comment was marked as outdated.

@cortisiko cortisiko changed the title test: Add launch tests to performance suite fix: cp-7.56.0 Add launch tests to performance suite Sep 18, 2025
@javiergarciavera javiergarciavera requested a review from a team as a code owner September 18, 2025 15:35
cursor[bot]

This comment was marked as outdated.

cortisiko
cortisiko previously approved these changes Sep 18, 2025
if (await closeButton.isVisible({ timeout })) {
await closeButton.tap();
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Modal Dismissal Functions Fail Gracefully

The dismissGTMModal and dismissMultichainAccountsIntroModal functions can throw an unhandled exception. This occurs because AppwrightSelectors.getElementByText and getElementByID throw an error if the target modal isn't found within the timeout, preventing graceful handling of its absence.

Fix in Cursor Fix in Web

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog required No changelog entry is required for this change No E2E Smoke Needed If the PR does not need E2E smoke test run no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-XL team-qa QA team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants