Skip to content

Added Wiki cmdlets#414

Merged
SebastianSchuetze merged 6 commits intoMethodsAndPractices:trunkfrom
gm0d:trunk
Sep 12, 2021
Merged

Added Wiki cmdlets#414
SebastianSchuetze merged 6 commits intoMethodsAndPractices:trunkfrom
gm0d:trunk

Conversation

@gm0d
Copy link
Contributor

@gm0d gm0d commented Aug 18, 2021

PR Summary

Added:

  • Add-VSTeamWiki
  • Get-VSTeamWiki
  • Remove-VSTeamWiki

to interact with provisioned and code wiki

PR Checklist

@SebastianSchuetze
Copy link
Contributor

@gm0d thanks for the PR. I can't commit anything to your PR. Either you fix the mistake yourself or you give me permission to commit to your PR.

You have a sample called refenced 'SampleFiles/Get-VSTeamWiki.json' but in your repo it is named 'Get-VsTeamWiki.json'. Mac and Linux are case sensitive. Please renamed the file to get the build run successfully.

Copy link
Contributor

@SebastianSchuetze SebastianSchuetze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR! It is good to see when good structured code and tests are written like the rest of the code in the module.

Just two minor changes would be nice before we can merge it.

Copy link
Contributor

@SebastianSchuetze SebastianSchuetze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gm0d Looks good. Just one thing. Could you pull the latest changes from our trunk. There was a Script Analyzer problem that I fixed. When the build is successfully running through, then I can merge it.

@SebastianSchuetze SebastianSchuetze merged commit 7325dbd into MethodsAndPractices:trunk Sep 12, 2021
@SebastianSchuetze
Copy link
Contributor

Never mind. Build was successful. So I am merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants