Add option to Merge or Overwrite Bits in Add-VSTeamAccessControlEntry#515
Merged
SebastianSchuetze merged 7 commits intoMethodsAndPractices:trunkfrom May 20, 2023
mrwalters1988:feature/ACEMerge
Merged
Add option to Merge or Overwrite Bits in Add-VSTeamAccessControlEntry#515SebastianSchuetze merged 7 commits intoMethodsAndPractices:trunkfrom mrwalters1988:feature/ACEMerge
SebastianSchuetze merged 7 commits intoMethodsAndPractices:trunkfrom
mrwalters1988:feature/ACEMerge
Conversation
Adding option to override the mask rather than always merging values.
Documenting new parameter.
Changing override to overwrite.
Contributor
Author
|
I didn't see any changes that needed to be made in the tests, and changelog looks like it's only updated when several PRs are approved and merged in, so I did not update that either. Can do so if needed. |
Contributor
Author
|
Any update on this? |
SebastianSchuetze
suggested changes
May 11, 2023
Contributor
SebastianSchuetze
left a comment
SebastianSchuetze
left a comment
There was a problem hiding this comment.
A new unit test is needed that tests your switch parameter. You need to test that the sent body includes the value set when overwriting. When you added the test and all is green. I will merge it. :-)
SebastianSchuetze
changed the title
SebastianSchuetze
approved these changes
May 20, 2023
SebastianSchuetze
changed the title
Contributor
Author
|
Thanks @SebastianSchuetze I had set aside time next week to add the unit test, but I appreciate you adding it for me. Happy to have contributed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This enables the option mentioned in the inline comments of Add-VSTeamAccessControlEntry to choose whether to merge the Bits or to Overwrite the bits.
PR Checklist