buildenv.py: don't set git author and committer name #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I rely on this ENV here https://github.com/SuperSandro2000/nixpkgs-review-checks/blob/master/bashrc#L122 Also IIRC this is required if git isn't configured because otherwise the git merge asks for a username. It could probably be also handed over there with command line args. Got introduced by #13 without any comment. |
Contributor
Author
|
git merge is called with --no-commit, so no commits are created |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents from creating misattributed commits when trying to do any git work on nixpkgs in the resulting shell.