Improve GitHub support #448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
force-pushed
the
improve-github-support
branch
2 times, most recently
from
08f4ec7 to
6555cad
Compare
We also require a github token to download github action results.
Mic92
force-pushed
the
improve-github-support
branch
from
5b6931b to
737e8b4
Compare
Owner
Author
trofi
reviewed
Jan 5, 2025
| # Allow substring match as hub uses yaml. Example string we match: | ||
| # " - oauth_token: ghp_abcdefghijklmnopqrstuvwxyzABCDEF1234\n" | ||
| token_match = re.search( | ||
| r"\s*oauth_token:\s+((?:gh[po]_)?[A-Za-z0-9]+)", line |
Contributor
There was a problem hiding this comment.
This removes reading of the token from the hub tool. It looks unrelated to ofborg removal. Is the removal intentional?
Owner
Author
There was a problem hiding this comment.
Yes we had several instances where this token was out of date. Also hub now often stores git hub tokens in platform specific keychains. Using GH is better because the token than should always work and not leave the user with a 403 error, that they have to debug.
Contributor
There was a problem hiding this comment.
Aha, thank you! I'll try to migrate from hub to gh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.