Skip to content

Show --skip-package (and friends) in the report#460

Merged
GaetanLepage merged 1 commit intoMic92:masterfrom
PerchunPak:show-skip-packages-in-report
Feb 2, 2025
Merged

Show --skip-package (and friends) in the report#460
GaetanLepage merged 1 commit intoMic92:masterfrom
PerchunPak:show-skip-packages-in-report

Conversation

@PerchunPak
Copy link
Contributor

@PerchunPak
Copy link
Contributor Author

Unnable to test, I broke my nixpkgs clone so I am clonning it all over again

@GaetanLepage
Copy link
Collaborator

Thanks ! Maybe add skip-package-regex too.

What would have been great is to list packages that have actually been skipped.
This implies keeping track of the packages filtered in the evaluation process.

But this is still an improvement.

@PerchunPak PerchunPak force-pushed the show-skip-packages-in-report branch 2 times, most recently from cf1be93 to 840fbc7 Compare February 2, 2025 17:39
@PerchunPak PerchunPak changed the title Show --skip-package in the report Show --skip-package (and friends) in the report Feb 2, 2025
@PerchunPak
Copy link
Contributor Author

What would have been great is to list packages that have actually been skipped.
This implies keeping track of the packages filtered in the evaluation process.

That requires a refactor, and I don't really want to do it

@GaetanLepage
Copy link
Collaborator

That requires a refactor, and I don't really want to do it

Yes, I started to do it locally and it is not that easy.
We should definitely not do it in this PR.

@PerchunPak PerchunPak force-pushed the show-skip-packages-in-report branch from 840fbc7 to b120e58 Compare February 2, 2025 17:42
@GaetanLepage GaetanLepage merged commit 4e9994d into Mic92:master Feb 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants