Fix log rendering with < and > #526
Merged
wolfgangwalther merged 2 commits intoMic92:masterfrom Jul 7, 2025
Merged
Conversation
When the log contains something that looks like a HTML tag, those will silently disappear. Properly escape these to make them show up in the GitHub comment. Resolves Mic92#502
Technically this is already checked in the `if` condition, but mypy still complains with: ``` nixpkgs_review/cli/__init__.py:154: error: Item "None" of "str | None" has no attribute "split" [union-attr] ```
SuperSandro2000
approved these changes
Jul 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the log contains something that looks like a HTML tag, those will silently disappear. Properly escape these to make them show up in the GitHub comment.
Resolves #502
@pbsds