tests: add and fix tests for --extra-nixpkgs-config and buildEnv#580
Merged
Mic92 merged 3 commits intoMic92:masterfrom Dec 22, 2025
Merged
tests: add and fix tests for --extra-nixpkgs-config and buildEnv#580Mic92 merged 3 commits intoMic92:masterfrom
Mic92 merged 3 commits intoMic92:masterfrom
Conversation
Currently this only happens when there are more than 50 packages and buildEnv is used. If review-shell doesn't actually build all the packages passed to buildEnv, then it will fail when trying to get the logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new test that covers --extra-nixpkgs-config, as well as building more than the 50 package threshold in review-shell.nix. It also has fixes for both of those features in testing.