Quote object keys

[MichaelDoyle]

No description provided.

[gemini-code-assist]

Hello @MichaelDoyle, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello team, gemini-code-assist here to provide a summary of this pull request. Based on the title "Quote object keys" and the single file change, it appears this PR aims to modify the display of JSON object keys within the tree view component. Specifically, it updates the template to render object keys enclosed in double quotes, which is a standard representation in JSON.

Highlights

• JSON Key Display: The primary change is to the ngx-json-treeview.component.html template to ensure that JSON object keys are displayed with surrounding double quotes.

Changelog

• projects/ngx-json-treeview/src/lib/ngx-json-treeview.component.html
  • Modified the template to wrap the displayed segment.key with double quotes using Angular's interpolation syntax ({{ "${segment.key}" }}). This change is located on line 33.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Keys need quotes now,
JSON structure shown clearly,
Tree view looks correct.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a small but effective change to quote object keys (and array indices treated as keys) in the JSON tree view. This enhances the visual representation, making it more consistent with standard JSON notation. The implementation is clean and directly addresses the goal. Well done!

Summary of Findings

• Consistent Key Quoting: The change correctly quotes segment.key values in the template, which applies to both object property names and array indices (e.g., "0", "1") as they are rendered. This creates a more uniform and JSON-like appearance for all keys displayed in the tree view. This is a positive enhancement for visual consistency. (Severity: Low - not commented directly on the code due to review settings requesting comments only for medium, high, or critical issues).

Merge Readiness

The changes in this pull request are straightforward and improve the component's display. I see no major issues. Based on this review, the pull request appears ready for merging. As always, ensure any CI checks pass and consider if further testing is appropriate for your project's standards. I am not authorized to approve the pull request, so please have other reviewers approve it before merging.