Skip to content

Conversation

@RavuAlHemio
Copy link

These landing pages only link to the direct subpages, but that works better than having links pointing at those expected landing pages redirect to the "how do I install WinDbg" page.

@prmerger-automator
Copy link
Contributor

@RavuAlHemio : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit b10b4d8:

⚠️ Validation status: warnings

File Status Preview URL Details
⚠️Warning Details
windows-driver-docs-pr/debugger/dbgeng-extension-design-guide.md ✅Succeeded
windows-driver-docs-pr/debugger/toc.yml ✅Succeeded
windows-driver-docs-pr/debugger/wdbgexts-extension-design-guide.md ✅Succeeded

  • Line 0, Column 0: [Warning: redirected-file-not-removed - See documentation] Redirected file 'debugger/dbgeng-extension-design-guide.md' are still in the repo. After adding a file to the redirection JSON file, you must delete the original file from the repo.
  • Line 0, Column 0: [Warning: redirected-file-not-removed - See documentation] Redirected file 'debugger/wdbgexts-extension-design-guide.md' are still in the repo. After adding a file to the redirection JSON file, you must delete the original file from the repo.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@Bradben Bradben removed the request for review from mhopkins-msft December 25, 2025 17:38
These landing pages only link to the direct subpages, but that works better
than having links pointing at those expected landing pages redirect to the
"how do I install WinDbg" page.
@RavuAlHemio RavuAlHemio force-pushed the windbg-ext-design-guides branch from b10b4d8 to d802b82 Compare December 26, 2025 12:47
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit d802b82:

💡 Validation status: suggestions

File Status Preview URL Details
windows-driver-docs-pr/debugger/dbgeng-extension-design-guide.md 💡Suggestion Details
windows-driver-docs-pr/debugger/wdbgexts-extension-design-guide.md 💡Suggestion Details
.openpublishing.redirection.json ✅Succeeded
windows-driver-docs-pr/debugger/toc.yml ✅Succeeded

windows-driver-docs-pr/debugger/dbgeng-extension-design-guide.md

  • Line 0, Column 0: [Suggestion: filename-incomplete - See documentation] The filename contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.

windows-driver-docs-pr/debugger/wdbgexts-extension-design-guide.md

  • Line 0, Column 0: [Suggestion: filename-incomplete - See documentation] The filename contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
File Change Percent This PR contains file(s) with more than 30% file change.
Json File This PR contains json file(s).

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reintroduces two landing pages for debugger extension design guides (DbgEng and WdbgExts) that were previously redirected to the main debugger page. The landing pages provide a clear entry point with links to their respective subpages.

  • Creates new landing pages for DbgEng and WdbgExts extension design guides
  • Updates the table of contents to reference the new landing pages
  • Removes redirect entries that were sending these pages to the main debugger installation page

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
windows-driver-docs-pr/debugger/wdbgexts-extension-design-guide.md New landing page for WdbgExts Extension Design Guide with links to 6 subtopics
windows-driver-docs-pr/debugger/dbgeng-extension-design-guide.md New landing page for DbgEng Extension Design Guide with links to 4 subtopics
windows-driver-docs-pr/debugger/toc.yml Adds entries for both landing pages in the table of contents structure
.openpublishing.redirection.json Removes redirect entries for both design guide pages so they can function as proper landing pages

Comment on lines +5 to +6
ms.date: 05/23/2017
ms.topic: concept-article
Copy link

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ms.date value of '05/23/2017' appears to be outdated and does not reflect when this content is being created. The date should be updated to reflect the current date or the date when this content is being added to the documentation.

Suggested change
ms.date: 05/23/2017
ms.topic: concept-article
ms.date: 12/29/2025
ms.topic: concept-article
ai-usage: ai-assisted

Copilot uses AI. Check for mistakes.
Comment on lines +5 to +6
ms.date: 05/23/2017
ms.topic: concept-article
Copy link

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ms.date value of '05/23/2017' appears to be outdated and does not reflect when this content is being created. The date should be updated to reflect the current date or the date when this content is being added to the documentation.

Suggested change
ms.date: 05/23/2017
ms.topic: concept-article
ms.date: 12/29/2025
ms.topic: concept-article
ai-usage: ai-assisted

Copilot uses AI. Check for mistakes.
Comment on lines +1 to +7
---
title: WdbgExts Extension Design Guide
description: WdbgExts Extension Design Guide
keywords: WdbgExts Extensions, debugger extensions
ms.date: 05/23/2017
ms.topic: concept-article
---
Copy link

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ai-usage metadata attribute is missing from the YAML frontmatter. According to the repository guidelines, when Copilot creates or modifies content, the 'ai-usage: ai-assisted' attribute must be included in the YAML frontmatter.

Copilot generated this review using guidance from repository custom instructions.
Comment on lines +1 to +7
---
title: DbgEng Extension Design Guide
description: DbgEng Extension Design Guide
keywords: DbgEng Extensions, debugger extensions
ms.date: 05/23/2017
ms.topic: concept-article
---
Copy link

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ai-usage metadata attribute is missing from the YAML frontmatter. According to the repository guidelines, when Copilot creates or modifies content, the 'ai-usage: ai-assisted' attribute must be included in the YAML frontmatter.

Copilot generated this review using guidance from repository custom instructions.
@v-regandowner
Copy link
Contributor

@Bradben @EliotSeattle

If you approve the reintroduced content in this PR, the commits must be moved to the private repository for automated checks and publishing. After you move the commits, close this PR (#please-close). If you need help moving the commits, contact the publicprs alias.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants