All FCMAndroidConfig fields optional #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MihaelIsaev
reviewed
Jul 25, 2021
MihaelIsaev
reviewed
Jul 25, 2021
Owner
MihaelIsaev
left a comment
MihaelIsaev
left a comment
There was a problem hiding this comment.
Have you tested and sure that it works well with all optional fields?
Contributor
Author
|
It works fine yes. |
Contributor
Author
|
I reverted back the default value for the priority, the other values are all optional, so these should not change anything for existing library users. |
MihaelIsaev
approved these changes
Jul 26, 2021
Owner
|
@sroebert thank you very much for the contribution! These changes are now available since 2.11.0 tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All fields in
FCMAndroidConfigare suppose to be optional. Since you currently cannot create theFCMAndroidConfigfor only setting one particular field, this PR makes all fields optional, allowing to only set certain parameters.