Skip to content

[X64] [stephentoub] Clean up some [InlineArray] use #291

Open
@MihuBot

Description

@MihuBot

Build completed in 1 hour 45 minutes.
dotnet/runtime#99766

Diffs

Found 304 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 39005111
Total bytes of diff: 39005275
Total bytes of delta: 164 (0.00 % of base)
Total relative delta: Infinity
    diff is a regression.
    relative diff is a regression.


Total byte diff includes -156 bytes from reconciling methods
	Base had    9 unique methods,      202 unique bytes
	Diff had    8 unique methods,       46 unique bytes

Top file regressions (bytes):
         384 : System.Net.Sockets.dasm (0.15 % of base)
          14 : Microsoft.Extensions.DependencyInjection.Abstractions.dasm (0.02 % of base)

Top file improvements (bytes):
        -234 : System.Private.CoreLib.dasm (-0.00 % of base)

3 total files with Code Size differences (1 improved, 2 regressed), 253 unchanged.

Top method regressions (bytes):
         384 (Infinity of base) : System.Net.Sockets.dasm - System.Net.Sockets.SocketAsyncEngine:EventLoop():this (FullOpts)
           6 (Infinity of base) : Microsoft.Extensions.DependencyInjection.Abstractions.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[double,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           6 (Infinity of base) : Microsoft.Extensions.DependencyInjection.Abstractions.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[int,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           6 (Infinity of base) : Microsoft.Extensions.DependencyInjection.Abstractions.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[long,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           6 (Infinity of base) : Microsoft.Extensions.DependencyInjection.Abstractions.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[short,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           6 (Infinity of base) : Microsoft.Extensions.DependencyInjection.Abstractions.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[System.Nullable`1[int],System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           6 (Infinity of base) : Microsoft.Extensions.DependencyInjection.Abstractions.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[System.Numerics.Vector`1[float],System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           6 (Infinity of base) : Microsoft.Extensions.DependencyInjection.Abstractions.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[ubyte,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           4 (Infinity of base) : Microsoft.Extensions.DependencyInjection.Abstractions.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[System.__Canon,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)

Top method improvements (bytes):
         -92 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Buffers.EightPackedReferences:.ctor(System.ReadOnlySpan`1[System.Object]):this (FullOpts) (1 base, 0 diff methods)
         -32 (-1.71 % of base) : Microsoft.Extensions.DependencyInjection.Abstractions.dasm - Microsoft.Extensions.DependencyInjection.ActivatorUtilities:CreateInstance(System.IServiceProvider,System.Type,System.Object[]):System.Object (FullOpts)
         -25 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Reflection.MethodBase+ArgumentData`1[System.Numerics.Vector`1[float]]:Set(int,System.Numerics.Vector`1[float]):this (FullOpts) (1 base, 0 diff methods)
         -20 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Reflection.MethodBase+ArgumentData`1[System.__Canon]:Set(int,System.__Canon):this (FullOpts) (1 base, 0 diff methods)
         -14 (-5.93 % of base) : System.Private.CoreLib.dasm - System.Runtime.Loader.AssemblyLoadContext:GetResolvedUnmanagedDll(System.Reflection.Assembly,System.String):long:this (FullOpts)
         -12 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Reflection.MethodBase+ArgumentData`1[double]:Set(int,double):this (FullOpts) (1 base, 0 diff methods)
         -11 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Reflection.MethodBase+ArgumentData`1[long]:Set(int,long):this (FullOpts) (1 base, 0 diff methods)
         -11 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Reflection.MethodBase+ArgumentData`1[short]:Set(int,short):this (FullOpts) (1 base, 0 diff methods)
         -11 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Reflection.MethodBase+ArgumentData`1[System.Nullable`1[int]]:Set(int,System.Nullable`1[int]):this (FullOpts) (1 base, 0 diff methods)
         -11 (-1.25 % of base) : System.Private.CoreLib.dasm - System.Runtime.Loader.AssemblyLoadContext:GetFirstResolvedAssemblyFromResolvingEvent(System.Reflection.AssemblyName):System.Reflection.Assembly:this (FullOpts)
         -10 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Reflection.MethodBase+ArgumentData`1[int]:Set(int,int):this (FullOpts) (1 base, 0 diff methods)
         -10 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Reflection.MethodBase+ArgumentData`1[ubyte]:Set(int,ubyte):this (FullOpts) (1 base, 0 diff methods)
          -7 (-0.79 % of base) : System.Private.CoreLib.dasm - System.Runtime.Loader.AssemblyLoadContext:InvokeResolveEvent(System.ResolveEventHandler,System.Reflection.RuntimeAssembly,System.String):System.Reflection.RuntimeAssembly (FullOpts)

Top method regressions (percentages):
           6 (Infinity of base) : Microsoft.Extensions.DependencyInjection.Abstractions.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[double,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           6 (Infinity of base) : Microsoft.Extensions.DependencyInjection.Abstractions.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[int,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           6 (Infinity of base) : Microsoft.Extensions.DependencyInjection.Abstractions.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[long,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           6 (Infinity of base) : Microsoft.Extensions.DependencyInjection.Abstractions.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[short,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           4 (Infinity of base) : Microsoft.Extensions.DependencyInjection.Abstractions.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[System.__Canon,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           6 (Infinity of base) : Microsoft.Extensions.DependencyInjection.Abstractions.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[System.Nullable`1[int],System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           6 (Infinity of base) : Microsoft.Extensions.DependencyInjection.Abstractions.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[System.Numerics.Vector`1[float],System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
           6 (Infinity of base) : Microsoft.Extensions.DependencyInjection.Abstractions.dasm - <PrivateImplementationDetails>:InlineArrayAsSpan[ubyte,System.Nullable`1[int]](byref,int):System.Span`1[System.Nullable`1[int]] (FullOpts) (0 base, 1 diff methods)
         384 (Infinity of base) : System.Net.Sockets.dasm - System.Net.Sockets.SocketAsyncEngine:EventLoop():this (FullOpts)

Top method improvements (percentages):
         -92 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Buffers.EightPackedReferences:.ctor(System.ReadOnlySpan`1[System.Object]):this (FullOpts) (1 base, 0 diff methods)
         -12 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Reflection.MethodBase+ArgumentData`1[double]:Set(int,double):this (FullOpts) (1 base, 0 diff methods)
         -10 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Reflection.MethodBase+ArgumentData`1[int]:Set(int,int):this (FullOpts) (1 base, 0 diff methods)
         -11 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Reflection.MethodBase+ArgumentData`1[long]:Set(int,long):this (FullOpts) (1 base, 0 diff methods)
         -11 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Reflection.MethodBase+ArgumentData`1[short]:Set(int,short):this (FullOpts) (1 base, 0 diff methods)
         -20 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Reflection.MethodBase+ArgumentData`1[System.__Canon]:Set(int,System.__Canon):this (FullOpts) (1 base, 0 diff methods)
         -11 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Reflection.MethodBase+ArgumentData`1[System.Nullable`1[int]]:Set(int,System.Nullable`1[int]):this (FullOpts) (1 base, 0 diff methods)
         -25 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Reflection.MethodBase+ArgumentData`1[System.Numerics.Vector`1[float]]:Set(int,System.Numerics.Vector`1[float]):this (FullOpts) (1 base, 0 diff methods)
         -10 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Reflection.MethodBase+ArgumentData`1[ubyte]:Set(int,ubyte):this (FullOpts) (1 base, 0 diff methods)
         -14 (-5.93 % of base) : System.Private.CoreLib.dasm - System.Runtime.Loader.AssemblyLoadContext:GetResolvedUnmanagedDll(System.Reflection.Assembly,System.String):long:this (FullOpts)
         -32 (-1.71 % of base) : Microsoft.Extensions.DependencyInjection.Abstractions.dasm - Microsoft.Extensions.DependencyInjection.ActivatorUtilities:CreateInstance(System.IServiceProvider,System.Type,System.Object[]):System.Object (FullOpts)
         -11 (-1.25 % of base) : System.Private.CoreLib.dasm - System.Runtime.Loader.AssemblyLoadContext:GetFirstResolvedAssemblyFromResolvingEvent(System.Reflection.AssemblyName):System.Reflection.Assembly:this (FullOpts)
          -7 (-0.79 % of base) : System.Private.CoreLib.dasm - System.Runtime.Loader.AssemblyLoadContext:InvokeResolveEvent(System.ResolveEventHandler,System.Reflection.RuntimeAssembly,System.String):System.Reflection.RuntimeAssembly (FullOpts)

22 total methods with Code Size differences (13 improved, 9 regressed), 239666 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions