Skip to content

[JitDiff X64] [AndyAyersMS] JIT: boost inlining when callee unboxes an arg #810

Open
@MihuBot

Description

@MihuBot

Job completed in 14 minutes 26 seconds.
dotnet/runtime#110596

Diffs

Found 267 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 40203327
Total bytes of diff: 40206665
Total bytes of delta: 3338 (0.01 % of base)
Total relative delta: 4.10
    diff is a regression.
    relative diff is a regression.


Top file regressions (bytes):
        2694 : System.Configuration.ConfigurationManager.dasm (0.67 % of base)
         266 : System.Net.Http.dasm (0.03 % of base)
         225 : System.Private.DataContractSerialization.dasm (0.02 % of base)
          92 : System.Text.RegularExpressions.dasm (0.01 % of base)
          22 : System.ComponentModel.Composition.dasm (0.01 % of base)
          20 : System.Private.CoreLib.dasm (0.00 % of base)
          19 : Microsoft.CSharp.dasm (0.01 % of base)

7 total files with Code Size differences (0 improved, 7 regressed), 252 unchanged.

Top method regressions (bytes):
        1051 (62.01 % of base) : System.Configuration.ConfigurationManager.dasm - System.Configuration.ConfigurationElement:UnMergeLockList(System.Configuration.ConfigurationLockCollection,System.Configuration.ConfigurationLockCollection,int):System.Configuration.ConfigurationLockCollection:this (FullOpts)
         880 (33.45 % of base) : System.Configuration.ConfigurationManager.dasm - System.Configuration.ConfigurationElement:MergeLocks(System.Configuration.ConfigurationElement):this (FullOpts)
         323 (19.67 % of base) : System.Configuration.ConfigurationManager.dasm - System.Configuration.ConfigurationElement:ParseLockedAttributes(System.Configuration.ConfigurationValue,int):System.Configuration.ConfigurationLockCollection:this (FullOpts)
         266 (24.88 % of base) : System.Net.Http.dasm - System.Net.Http.Headers.HttpHeaders:TryParseAndAddRawHeaderValue(System.Net.Http.Headers.HeaderDescriptor,System.Net.Http.Headers.HttpHeaders+HeaderStoreItemInfo,System.String,ubyte):ubyte (FullOpts)
         225 (8.42 % of base) : System.Private.DataContractSerialization.dasm - System.Runtime.Serialization.Json.JsonFormatReaderGenerator+CriticalHelper:ReadSimpleDictionary(System.Runtime.Serialization.DataContracts.CollectionDataContract,System.Type):this (FullOpts)
         116 (63.74 % of base) : System.Configuration.ConfigurationManager.dasm - System.Configuration.TimeSpanMinutesOrInfiniteConverter:ConvertTo(System.ComponentModel.ITypeDescriptorContext,System.Globalization.CultureInfo,System.Object,System.Type):System.Object:this (FullOpts)
         116 (63.74 % of base) : System.Configuration.ConfigurationManager.dasm - System.Configuration.TimeSpanSecondsOrInfiniteConverter:ConvertTo(System.ComponentModel.ITypeDescriptorContext,System.Globalization.CultureInfo,System.Object,System.Type):System.Object:this (FullOpts)
         105 (8.68 % of base) : System.Configuration.ConfigurationManager.dasm - System.Configuration.ConfigurationElement:ResetLockLists(System.Configuration.ConfigurationElement):this (FullOpts)
          55 (6.12 % of base) : System.Configuration.ConfigurationManager.dasm - System.Configuration.ConfigurationLockCollection:ClearInternal(ubyte):this (FullOpts)
          52 (31.71 % of base) : System.Text.RegularExpressions.dasm - System.Text.RegularExpressions.GroupCollection:GetGroup(int):System.Text.RegularExpressions.Group:this (FullOpts)
          48 (8.60 % of base) : System.Configuration.ConfigurationManager.dasm - System.Configuration.ConfigurationLockCollection:.ctor(System.Configuration.ConfigurationElement,int,System.String,System.Configuration.ConfigurationLockCollection):this (FullOpts)
          40 (24.39 % of base) : System.Text.RegularExpressions.dasm - System.Text.RegularExpressions.RegexParser:GroupNameFromNumber(System.Collections.Hashtable,System.String[],int,int):System.String (FullOpts)
          22 (9.09 % of base) : System.ComponentModel.Composition.dasm - System.ComponentModel.Composition.Hosting.ScopingExtensions:ContainsPartMetadata[long](System.ComponentModel.Composition.Primitives.ComposablePartDefinition,System.String,long):ubyte (FullOpts)
          20 (42.55 % of base) : System.Private.CoreLib.dasm - System.Nullable`1[long]:Equals(System.Object):ubyte:this (FullOpts)
          19 (3.00 % of base) : Microsoft.CSharp.dasm - Microsoft.CSharp.RuntimeBinder.Semantics.ConstVal:IsDefault(System.Object):ubyte (FullOpts)

Top method regressions (percentages):
         116 (63.74 % of base) : System.Configuration.ConfigurationManager.dasm - System.Configuration.TimeSpanMinutesOrInfiniteConverter:ConvertTo(System.ComponentModel.ITypeDescriptorContext,System.Globalization.CultureInfo,System.Object,System.Type):System.Object:this (FullOpts)
         116 (63.74 % of base) : System.Configuration.ConfigurationManager.dasm - System.Configuration.TimeSpanSecondsOrInfiniteConverter:ConvertTo(System.ComponentModel.ITypeDescriptorContext,System.Globalization.CultureInfo,System.Object,System.Type):System.Object:this (FullOpts)
        1051 (62.01 % of base) : System.Configuration.ConfigurationManager.dasm - System.Configuration.ConfigurationElement:UnMergeLockList(System.Configuration.ConfigurationLockCollection,System.Configuration.ConfigurationLockCollection,int):System.Configuration.ConfigurationLockCollection:this (FullOpts)
          20 (42.55 % of base) : System.Private.CoreLib.dasm - System.Nullable`1[long]:Equals(System.Object):ubyte:this (FullOpts)
         880 (33.45 % of base) : System.Configuration.ConfigurationManager.dasm - System.Configuration.ConfigurationElement:MergeLocks(System.Configuration.ConfigurationElement):this (FullOpts)
          52 (31.71 % of base) : System.Text.RegularExpressions.dasm - System.Text.RegularExpressions.GroupCollection:GetGroup(int):System.Text.RegularExpressions.Group:this (FullOpts)
         266 (24.88 % of base) : System.Net.Http.dasm - System.Net.Http.Headers.HttpHeaders:TryParseAndAddRawHeaderValue(System.Net.Http.Headers.HeaderDescriptor,System.Net.Http.Headers.HttpHeaders+HeaderStoreItemInfo,System.String,ubyte):ubyte (FullOpts)
          40 (24.39 % of base) : System.Text.RegularExpressions.dasm - System.Text.RegularExpressions.RegexParser:GroupNameFromNumber(System.Collections.Hashtable,System.String[],int,int):System.String (FullOpts)
         323 (19.67 % of base) : System.Configuration.ConfigurationManager.dasm - System.Configuration.ConfigurationElement:ParseLockedAttributes(System.Configuration.ConfigurationValue,int):System.Configuration.ConfigurationLockCollection:this (FullOpts)
          22 (9.09 % of base) : System.ComponentModel.Composition.dasm - System.ComponentModel.Composition.Hosting.ScopingExtensions:ContainsPartMetadata[long](System.ComponentModel.Composition.Primitives.ComposablePartDefinition,System.String,long):ubyte (FullOpts)
         105 (8.68 % of base) : System.Configuration.ConfigurationManager.dasm - System.Configuration.ConfigurationElement:ResetLockLists(System.Configuration.ConfigurationElement):this (FullOpts)
          48 (8.60 % of base) : System.Configuration.ConfigurationManager.dasm - System.Configuration.ConfigurationLockCollection:.ctor(System.Configuration.ConfigurationElement,int,System.String,System.Configuration.ConfigurationLockCollection):this (FullOpts)
         225 (8.42 % of base) : System.Private.DataContractSerialization.dasm - System.Runtime.Serialization.Json.JsonFormatReaderGenerator+CriticalHelper:ReadSimpleDictionary(System.Runtime.Serialization.DataContracts.CollectionDataContract,System.Type):this (FullOpts)
          55 (6.12 % of base) : System.Configuration.ConfigurationManager.dasm - System.Configuration.ConfigurationLockCollection:ClearInternal(ubyte):this (FullOpts)
          19 (3.00 % of base) : Microsoft.CSharp.dasm - Microsoft.CSharp.RuntimeBinder.Semantics.ConstVal:IsDefault(System.Object):ubyte (FullOpts)

15 total methods with Code Size differences (0 improved, 15 regressed), 232918 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions