AspNetCore Package: ExcludeErrorsFromLocal is not respected

[bakermo]

Hello there!

We are utilizing the Mindscape.Raygun4Net.AspNetCore package and have discovered that ExcludeErrorsFromLocal on RaygunSettings is only being referenced by RaygunAspNetMiddleware:
https://github.com/MindscapeHQ/raygun4net/blob/c464d6da64e54996d8644f5ba920d9aec1158ec2/Mindscape.Raygun4Net.AspNetCore/RaygunAspNetMiddleware.cs#L81

There is no check against this setting in RaygunClient.cs, so any direct calls to Send() or SendInBackground() will send the exception even from local origins.

It appears this setting was working correctly in Mindscape.Raygun4Net.

[Loubear111]

It is a couple years later but I noticed I am having this exact same issue.

[phillip-haydon]

Hello @Loubear111,

We are slowly chipping away at the issues list, we will try bump this one up sooner.

[Loubear111]

@phillip-haydon That's great! I may have time to dig into this at some point as well and submit a PR if I do actually end up digging into it.

[phillip-haydon]

Hello @Loubear111, I'm happy for you to take a stab at it, I'll be away for a couple of weeks, back October 14th, and will pick this up then, implementation or reviewing. Thanks.

[teneko]

Few months later. I'm facing the same issue and have come to the same conclusion as @bakermo. 6k exceptions in development mode in short time! Workaround using Extensions.Hosting.AsyncInitialization:

using Extensions.Hosting.AsyncInitialization;
using Microsoft.Extensions.Hosting;
using Mindscape.Raygun4Net;

public class RaygunMessageFilterInitializer(RaygunClientBase raygunClient, IHostEnvironment hostEnvironment) : IAsyncInitializer
{
    private static readonly HashSet<string> s_environmentNameAllowlist = ["Production", "Staging"];

    public Task InitializeAsync(CancellationToken cancellationToken)
    {
        raygunClient.SendingMessage += OnRaygunClientSendingMessage;
        return Task.CompletedTask;
    }

    private void OnRaygunClientSendingMessage(object? sender, RaygunSendingMessageEventArgs e)
    {
        if (s_environmentNameAllowlist.Contains(hostEnvironment.EnvironmentName)) {
            return;
        }

        e.Cancel = true;
    }
}

...

services.AddAsyncInitializer<RaygunMessageFilterInitializer>();