This repository was archived by the owner on Oct 23, 2021. It is now read-only.
Added equals() and hashCode() to DiscordRichPresence #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @Override | ||
| public int hashCode() | ||
| { | ||
| return Objects.hash(state, details, startTimestamp, endTimestamp, largeImageKey, largeImageText, smallImageKey, |
There was a problem hiding this comment.
I believe the identity hashCode is better for JNA structures as they represent a pointer value
There was a problem hiding this comment.
That would contradict the general contract of hashCode() though.
If two objects are equal according to the equals(Object) method, then calling the hashCode method on each of the two objects must produce the same integer result.
There was a problem hiding this comment.
I see, I still want the other structs to get the same treatment ^^
| { | ||
| if (this == o) | ||
| return true; | ||
| if (o == null || getClass() != o.getClass()) |
There was a problem hiding this comment.
What's the reason not to use instanceof?
| if (!super.equals(o)) | ||
| return false; | ||
| DiscordEventHandlers that = (DiscordEventHandlers) o; | ||
| return Objects.equals(ready, that.ready) && Objects.equals(disconnected, that.disconnected) && Objects.equals(errored, that.errored) && Objects.equals(joinGame, that.joinGame) && Objects.equals(spectateGame, that.spectateGame) && Objects.equals(joinRequest, that.joinRequest); |
There was a problem hiding this comment.
Why is this line so long?
MinnDevelopment
approved these changes
Dec 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.