-
Notifications
You must be signed in to change notification settings - Fork 53
Heartbeat Manager #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Heartbeat Manager #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request introduces 3 alerts when merging 961923a into 75c8ccf - view on LGTM.com new alerts:
Comment posted by LGTM.com |
PyTest and cov will fail due to: Waiting another few hours should see it resolved. |
If anyone has a moment to review this let me know, otherwise merging sometime tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds manager heartbeats to the project. This allows jobs that have been allocated to managers that do not shut down properly to be recycled and given to other managers.
The heartbeat interval is set by the FractalServer instance and passed to the managers to ensure consistency.
Todos
kill
when run as background thread #90.Status