Skip to content

Conversation

@Anu6is
Copy link
Contributor

@Anu6is Anu6is commented Dec 10, 2024

Description

Currently when using column aggregates, users are restricted to outputting String values. This changes adds a new AggregateTemplate render fragment similar to the GroupTemplate render fragment that's available for grouping. Using the AggregateTemplate instead of the FooterTemplate as previously demonstrated in the Docs, gives the user access to the aggregated items instead of all page items.

Resolves #10410

How Has This Been Tested?

Visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library PR: needs review labels Dec 10, 2024
@codecov
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.51%. Comparing base (686f96c) to head (68cb099).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10419   +/-   ##
=======================================
  Coverage   91.50%   91.51%           
=======================================
  Files         418      418           
  Lines       13225    13225           
  Branches     2538     2538           
=======================================
+ Hits        12102    12103    +1     
  Misses        549      549           
+ Partials      574      573    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

@Anu6is Anu6is requested a review from ScarletKuro December 10, 2024 21:53
Copy link
Member

@ScarletKuro ScarletKuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the solution is elegant.

@ScarletKuro ScarletKuro merged commit e46df09 into MudBlazor:dev Dec 10, 2024
6 checks passed
@Anu6is Anu6is deleted the 10410-MudDataGrid-AggregateTemplate branch December 10, 2024 22:48
LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong aggregation value when using FooterTemplate in a grouping

2 participants