Skip to content

v5.3.0 #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2024
Merged

v5.3.0 #534

merged 3 commits into from
Nov 5, 2024

Conversation

itssimple
Copy link
Member

5.3.0 (2024-11-05)

Features

  • Handle API being down/blocked, instead of making the site hang until the configured timeout happens. (a1a5104), closes #153

We now have a configured timeout for the API client as the following:

  • Connection timeout: 0.5 seconds at most
  • Response timeout: 5 seconds at most (yes, if the API is slow, we will consider it down)

And in the plugin, we have also implemented a check that has a timeout of 0.25 seconds (but always goes for 1 second anyway for some reason), and if we decide that the API is not responding fast enough, a warning saying that the plugin cannot connect to the API will be shown.

In the admin pages, an error will be shown, with the suggestion to contact the EduAdmin Support for help.

Fixed another possible injection in template variables in course list view.

…until the configured timeout happens.

We now have a configured timeout for the API client as the following:
- Connection timeout: 0.5 seconds at most
- Response timeout: 5 seconds at most (yes, if the API is slow, we will consider it down)

And in the plugin, we have also implemented a check that has a timeout of 0.25 seconds (but always goes for 1 second anyway for some reason), and if we decide that the API is not responding fast enough, a warning saying that the plugin cannot connect to the API will be shown.

In the admin pages, an error will be shown, with the suggestion to contact the EduAdmin Support for help.

Fixed another possible injection in template variables in course list view.

fixes #153
@itssimple itssimple merged commit 538abf1 into production Nov 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add some kind of fallback/error message when we cannot connect to the API
1 participant