Refactor cghi.py for improved error handling and logging #1712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Improvements made a. Readability and consistency Clear use of f-strings. Use of logging instead of print for better control. b. Error handling HTTP error handling with response.raise_for_status(). Exception handling with try/except for requests. c. Best practices Removed the non-existent printer. Added User-Agent header (recommended by GitHub). Optional authentication token support via the GITHUB_TOKEN environment variable (avoids rate limits). d. More useful output In addition to counting, it shows the issue titles if desired. Added --show-issues parameter to display details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Improvements made
a. Readability and consistency
Clear use of f-strings.
Use of logging instead of print for better control.
b. Error handling
HTTP error handling with response.raise_for_status().
Exception handling with try/except for requests.
c. Best practices
Removed the non-existent printer.
Added User-Agent header (recommended by GitHub).
Optional authentication token support via the GITHUB_TOKEN environment variable (avoids rate limits).
d. More useful output
In addition to counting, it shows the issue titles if desired.
Added --show-issues parameter to display details.