Implement findaddpl command #2375
Open
+41
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+214
to
+225
| CommandResult | ||
| handle_findadd(Client &client, Request args, Response &) | ||
| { | ||
| return handle_match_add(client, args, false, false); | ||
| } | ||
|
|
||
| CommandResult | ||
| handle_searchadd(Client &client, Request args, Response &) | ||
| { | ||
| auto strip_diacritics = client.StringNormalizationEnabled(SN_STRIP_DIACRITICS); | ||
| return handle_match_add(client, args, true, strip_diacritics); | ||
| } |
Member
There was a problem hiding this comment.
Please don't move code around that you did not modify and that's not the target of your patch. That increases the diff size and is confusing.
Member
|
Documentation is missing - see doc/protocol.rst |
Member
|
Please amend the patch to not move code around. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2374