Skip to content

Location settings dialog#20

Open
hortemo wants to merge 3 commits into
MustansirZia:masterfrom
HoldGroup:resolve-location-settings
Open

Location settings dialog#20
hortemo wants to merge 3 commits into
MustansirZia:masterfrom
HoldGroup:resolve-location-settings

Conversation

@hortemo

@hortemo hortemo commented Feb 26, 2018

Copy link
Copy Markdown

Here is my draft for showing a dialog to programmatically set appropriate location settings. Based on https://developers.google.com/android/reference/com/google/android/gms/location/SettingsApi.

What are your thoughts?

@MustansirZia

Copy link
Copy Markdown
Owner

There is a very good PR I must say. I probably need to merge this and get this functionality in. But before I do that I need to dig deeper and see if I can refactor it a little more. For a start, may I ask why you used the depreciated Settings Api and not the newer SettingsClient?

@hortemo

hortemo commented Feb 27, 2018

Copy link
Copy Markdown
Author

Feel free to refactor! I used the deprecated SettingsApi because you already used the deprecated
FusedLocationProviderApi, and I thought those were from the same "generation" of APIs.

@MustansirZia

MustansirZia commented Feb 28, 2018

Copy link
Copy Markdown
Owner

@hortemo Alright. Would you be kind enough to send a PR with a SettingsClient usage instead? That'd be really great. As I'm planning to move on to the newer FusedLocationProviderClient pretty soon. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants