Location settings dialog#20
Open
hortemo wants to merge 3 commits into
Open
Conversation
Owner
|
There is a very good PR I must say. I probably need to merge this and get this functionality in. But before I do that I need to dig deeper and see if I can refactor it a little more. For a start, may I ask why you used the depreciated Settings Api and not the newer SettingsClient? |
Author
|
Feel free to refactor! I used the deprecated SettingsApi because you already used the deprecated |
Owner
|
@hortemo Alright. Would you be kind enough to send a PR with a SettingsClient usage instead? That'd be really great. As I'm planning to move on to the newer FusedLocationProviderClient pretty soon. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is my draft for showing a dialog to programmatically set appropriate location settings. Based on https://developers.google.com/android/reference/com/google/android/gms/location/SettingsApi.
What are your thoughts?