Skip to content

Provide an interface for RuleValueList|CSSFunction|CSSString|LineName|Size|URL #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
oliverklee opened this issue Feb 24, 2024 · 0 comments · Fixed by #507
Closed

Provide an interface for RuleValueList|CSSFunction|CSSString|LineName|Size|URL #499

oliverklee opened this issue Feb 24, 2024 · 0 comments · Fixed by #507
Assignees
@JakeQZ
Labels
cleanup
Milestone
9.0.0: Drop suppo...

Comments

@oliverklee
Copy link
Contributor

oliverklee commented Feb 24, 2024 •
edited
Loading

This will help us reduce some overlong type annotations in Color, CSSFunction, LineName, Value and ValueList.
@JakeQZ JakeQZ mentioned this issue Feb 26, 2024
Merged
@JakeQZ JakeQZ self-assigned this Feb 27, 2024
@JakeQZ JakeQZ added the cleanup label Feb 27, 2024
JakeQZ added a commit that referenced this issue Feb 27, 2024
@JakeQZ
[CLEANUP] Add an interface for components of a property value
9dfadef 
Resolves #499.
JakeQZ added a commit that referenced this issue Feb 27, 2024
@JakeQZ
[CLEANUP] Add an interface for components of a property value
a1f03ab 
Resolves #499.
@JakeQZ JakeQZ mentioned this issue Feb 27, 2024
Closed
JakeQZ added a commit that referenced this issue Feb 28, 2024
@JakeQZ
[CLEANUP] Use common ancestor Value in type specifications
a4abbf4 
Replace the list of various possible sub-types with the common ancestor.

Update the class diagram to indicate that `ValueList::$aComponents` no longer
depends on the sub-types.

Resolves #499.
JakeQZ added a commit that referenced this issue Feb 28, 2024
@JakeQZ
[CLEANUP] Use common ancestor Value in type specifications
f185d93 
Replace the list of various possible sub-types with the common ancestor.

Update the class diagram to indicate that `ValueList::$aComponents` no longer
has a dependency on the sub-types definitions.

Resolves #499.  Supersedes and closes #506.
JakeQZ added a commit that referenced this issue Feb 28, 2024
@JakeQZ
[CLEANUP] Use common ancestor Value in type specifications
4ed0795 
Replace the list of various possible sub-types with the common ancestor.

Update the class diagram to indicate that `ValueList::$aComponents` no longer
has a dependency on the sub-types definitions.

Resolves #499.  Supersedes and closes #506.
JakeQZ added a commit that referenced this issue Feb 28, 2024
@JakeQZ
[CLEANUP] Use common ancestor Value in type specifications
2db3cbd 
Replace the list of various possible sub-types with the common ancestor.

Update the class diagram to indicate that `ValueList::$aComponents` no longer
has a dependency on the sub-types definitions.

Resolves #499.  Supersedes and closes #506.
@JakeQZ JakeQZ mentioned this issue Feb 28, 2024
Merged
oliverklee pushed a commit that referenced this issue Mar 1, 2024
@JakeQZ
[CLEANUP] Use common ancestor Value in type specifications (#507)
086fa00 
Replace the list of various possible sub-types with the common ancestor.

Update the class diagram to indicate that `ValueList::$aComponents` no longer
has a dependency on the sub-types definitions.

Resolves #499. 
Supersedes and closes #506.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JakeQZ JakeQZ

Labels
cleanup
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
2 participants
@oliverklee @JakeQZ