Skip to content

CSS comments lead to exception #680

Open
@oliverklee

Description

@oliverklee

https://github.com/MyIntervals/emogrifier/actions/runs/10573250071/job/29292403949?pr=1248

1) Pelago\Emogrifer\Tests\Unit\CssInlinerTest::inlineCssFiltersUnneededCssThings with data set "CSS comments with one asterisk" ('p {color: #000;/* black */}', 'black')
Sabberworm\CSS\Parsing\UnexpectedTokenException: Identifier expected. Got “}” [line no: 1]

/home/runner/work/emogrifier/emogrifier/vendor/sabberworm/php-css-parser/src/Parsing/ParserState.php:143

We need to cover this with a test and fix it in main and for v8.x

@ziegenberg Would you be willing to have a look at this?

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions