Skip to content

Deprecate Parser::setCharset/getCharset #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
oliverklee opened this issue Aug 27, 2024 · 3 comments · Fixed by #688
Closed

Deprecate Parser::setCharset/getCharset #681

oliverklee opened this issue Aug 27, 2024 · 3 comments · Fixed by #688
Assignees
@oliverklee
Milestone
9.0.0: Drop suppo...

Comments

@oliverklee
Copy link
Contributor

Deprecate it in 8.x and remove it in 9.0.
@oliverklee oliverklee self-assigned this Aug 27, 2024
oliverklee added a commit that referenced this issue Aug 27, 2024
@oliverklee
[TASK] Deprecate Parser::setCharset() and Parser::getCharset()
d9edd5e 
Fixes #681
@oliverklee oliverklee mentioned this issue Aug 27, 2024
Merged
@JakeQZ
Copy link
Contributor

JakeQZ commented Aug 27, 2024

Shouldn't we deprecate it in 9.0 and remove it in 10.0? 8.x is already released.

@oliverklee
Copy link
Contributor Author

Once merged, I'd like to backport this deprecation to 8.x so the deprecation annotation will be in the hopefully-to-be-released-soon 8.7, which would allow us to remove the deprecated things in 9.0.

I'd also like to backport the other deprecations if possible (#696) for the same reason.

oliverklee added a commit that referenced this issue Aug 28, 2024
@oliverklee
[TASK] Deprecate Parser::setCharset() and Parser::getCharset()
d07b100 
Fixes #681
@JakeQZ
Copy link
Contributor

JakeQZ commented Aug 28, 2024

I'd like to backport this deprecation to 8.x so the deprecation annotation will be in the hopefully-to-be-released-soon 8.7, which would allow us to remove the deprecated things in 9.0.

OK. This is consistent with Semantic Versioning

oliverklee added a commit that referenced this issue Sep 1, 2024
@oliverklee
[TASK] Deprecate Parser::setCharset() and Parser::getCharset()
b1ccd56 
Fixes #681
oliverklee added a commit that referenced this issue Sep 1, 2024
@oliverklee
[TASK] Deprecate Parser::setCharset() and Parser::getCharset()
1ccd661 
Fixes #681
@JakeQZ JakeQZ closed this as completed in 1be844b Sep 2, 2024
oliverklee added a commit that referenced this issue Sep 3, 2024
@oliverklee
[TASK] Deprecate Parser::setCharset() and Parser::getCharset()
421f64f 
This is the backport of #688, which fixed #681.
@oliverklee oliverklee mentioned this issue Sep 3, 2024
Merged
JakeQZ pushed a commit that referenced this issue Sep 3, 2024
@oliverklee
[TASK] Deprecate Parser::setCharset() and Parser::getCharset() (#703
592f416 
)

This is the backport of #688, which fixed #681.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging a pull request may close this issue.

[TASK] Deprecate Parser::setCharset() and Parser::getCharset() MyIntervals/PHP-CSS-Parser
2 participants
@oliverklee @JakeQZ