[TASK] Deprecate __toString()

[oliverklee]

Part of #998

[coveralls]

coverage: 54.784%. remained the same
when pulling 595da81 on deprecate/to-string
into 215c199 on main.

[JakeQZ]

The deprecation notices are all fine, but the moving of a test would seem to belong in a separate PR (if required at all).

[JakeQZ]

Why is this method being moved here to test something that's deprecated? Shouldn't the introduction of the test class be a separate PR?

[oliverklee]

I'm moving this one test from Tests/Functional/ to Tests/FunctionalDeprecated/, where tests for deprecated functionality should be placed. (This will allow us to have different PHPUnit configuration files later on, allowing calls to deprecated functionality in Tests/FunctionalDeprecated/, but not in Tests/Functional/.)

[JakeQZ]

Apologies. I overlooked the location of where this was being moved to, and instead assumed (without looking) it was a new test class being created in the tests/Unit directory.

That said, I'm now wondering why the CommentTest class is in Functional rather than Unit, given that it appears to be a unit test for the Comment class - but that's beyond the scope of this PR.

[JakeQZ]

My mistake in previous review. Though I do have a further question in the comments.

[JakeQZ]

Apologies. I overlooked the location of where this was being moved to, and instead assumed (without looking) it was a new test class being created in the tests/Unit directory.

That said, I'm now wondering why the CommentTest class is in Functional rather than Unit, given that it appears to be a unit test for the Comment class - but that's beyond the scope of this PR.

[oliverklee]

That said, I'm now wondering why the CommentTest class is in Functional rather than Unit, given that it appears to be a unit test for the Comment class - but that's beyond the scope of this PR.

I see the tests for render (and for __toString) as we're testing the tested class in conjunction with OutputFormat and OutputFormatter instead of the tested class in isolation.

[JakeQZ]

That said, I'm now wondering why the CommentTest class is in Functional rather than Unit, given that it appears to be a unit test for the Comment class - but that's beyond the scope of this PR.

I see the tests for render (and for __toString) as we're testing the tested class in conjunction with OutputFormat and OutputFormatter instead of the tested class in isolation.

I (originally) saw the functional tests department as mainly a place for testing the various CSS conent that is in tests/fixtures that does not test any class directly. But yes, I see in CommentTest we are testing the behaviour in conjunction with OutputFormat, which cannot be done in isolation.