[TASK] Also allow higher versions of PHPUnit#682
Merged
Conversation
oliverklee
force-pushed
the
task/more-phpunit-versions
branch
from
dbee5c0 to
a1f7489
Compare
oliverklee
force-pushed
the
task/more-phpunit-versions
branch
from
4b9fb2c to
d8215c2
Compare
This hopefully will allow us to run the unit tests for all PHP version that we claim to support, i.e., from 5.6.x to currently 8.4.x.
oliverklee
force-pushed
the
task/more-phpunit-versions
branch
from
d8215c2 to
d1efe1c
Compare
JakeQZ
reviewed
Aug 28, 2024
Collaborator
JakeQZ
left a comment
JakeQZ
left a comment
There was a problem hiding this comment.
Is fine, but just one question.
composer.json
Outdated
| }, | ||
| "require-dev": { | ||
| "phpunit/phpunit": "^5.7.27" | ||
| "phpunit/phpunit": "^5.7.27 || ^8.5.39" |
Collaborator
There was a problem hiding this comment.
Is there any reason not to allow 6.x or 7.x? Or maybe there is no reason to allow them.
Collaborator
Author
There was a problem hiding this comment.
I see how this can be confusing to the reader. I've now added the major versions between 5 and 8 as well. Fingers crossed that this works out well …
oliverklee
force-pushed
the
task/more-phpunit-versions
branch
from
b84924e to
4e8fbc4
Compare
JakeQZ
approved these changes
Aug 29, 2024
westonruter
added a commit
to westonruter/PHP-CSS-Parser
that referenced
this pull request
Nov 4, 2024
…into fix/malformed-identifier * 'v8.x' of https://github.com/MyIntervals/PHP-CSS-Parser: (46 commits) [CLEANUP] Autoformat the code (MyIntervals#749) [TASK] Prepare the 8.7.0 release (MyIntervals#742) [BUGFIX] Fix another implictly nullable parameter (MyIntervals#751) [CLEANUP] Autoformat the changelog (MyIntervals#750) [TASK] Configure PHPUnit to be more strict (MyIntervals#744) [BUGFIX] Avoid implicit nullable parameters (MyIntervals#746) [BUGFIX] Revert broken support for multiple comments (MyIntervals#741) [TASK] Add some more tests for parsing comments (MyIntervals#739) [TASK] Use fixed PHPUnit versions (MyIntervals#726) [TASK] Update PHPUnit (MyIntervals#725) [TASK] State since which version code is `@internal`/`@deprecated` (MyIntervals#723) [TASK] Deprecate the expansion of shorthand properties (MyIntervals#719) [TASK] Mark parsing-internal classes and methods as `@internal` (MyIntervals#711) [TASK] Deprecate `Parser::setCharset()` and `Parser::getCharset()` (MyIntervals#703) [FEATURE] Run the tests on CI with PHP 8.4 as well (MyIntervals#701) [TASK] Run the tests with PHP versions up to 8.3 (MyIntervals#697) [TASK] Also allow higher versions of PHPUnit (MyIntervals#682) [BUGFIX] Fix type errors in PHP strict mode (MyIntervals#695) [TASK] Block installations on unsupported higher PHP versions (MyIntervals#692) [BUGFIX] Avoid using `setUp()` in testcases (MyIntervals#683) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hopefully will allow us to run the unit tests for all PHP version that we claim to support, i.e., from 5.6.x to currently 8.4.x.