Skip to content

[BUGFIX] Avoid using setUp() in testcases #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2024
Merged

[BUGFIX] Avoid using setUp() in testcases #683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion tests/CSSList/DocumentTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ final class DocumentTest extends TestCase
*/
private $subject;

protected function setUp()
private function setUpTestcase()
{
$this->subject = new Document();
}
Expand All @@ -28,6 +28,8 @@ protected function setUp()
*/
public function implementsRenderable()
{
$this->setUpTestcase();

self::assertInstanceOf(Renderable::class, $this->subject);
}

Expand All @@ -36,6 +38,8 @@ public function implementsRenderable()
*/
public function implementsCommentable()
{
$this->setUpTestcase();

self::assertInstanceOf(Commentable::class, $this->subject);
}

Expand All @@ -44,6 +48,8 @@ public function implementsCommentable()
*/
public function getContentsInitiallyReturnsEmptyArray()
{
$this->setUpTestcase();

self::assertSame([], $this->subject->getContents());
}

Expand All @@ -68,6 +74,8 @@ public static function contentsDataProvider()
*/
public function setContentsSetsContents(array $contents)
{
$this->setUpTestcase();

$this->subject->setContents($contents);

self::assertSame($contents, $this->subject->getContents());
Expand All @@ -78,6 +86,8 @@ public function setContentsSetsContents(array $contents)
*/
public function setContentsReplacesContentsSetInPreviousCall()
{
$this->setUpTestcase();

$contents2 = [new DeclarationBlock()];

$this->subject->setContents([new DeclarationBlock()]);
Expand All @@ -91,6 +101,8 @@ public function setContentsReplacesContentsSetInPreviousCall()
*/
public function insertContentBeforeInsertsContentBeforeSibbling()
{
$this->setUpTestcase();

$bogusOne = new DeclarationBlock();
$bogusOne->setSelectors('.bogus-one');
$bogusTwo = new DeclarationBlock();
Expand All @@ -117,6 +129,8 @@ public function insertContentBeforeInsertsContentBeforeSibbling()
*/
public function insertContentBeforeAppendsIfSibblingNotFound()
{
$this->setUpTestcase();

$bogusOne = new DeclarationBlock();
$bogusOne->setSelectors('.bogus-one');
$bogusTwo = new DeclarationBlock();
Expand Down
8 changes: 7 additions & 1 deletion tests/CSSList/KeyFrameTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ final class KeyFrameTest extends TestCase
*/
protected $subject;

protected function setUp()
private function setUpTestcase()
{
$this->subject = new KeyFrame();
}
Expand All @@ -28,6 +28,8 @@ protected function setUp()
*/
public function implementsAtRule()
{
$this->setUpTestcase();

self::assertInstanceOf(AtRule::class, $this->subject);
}

Expand All @@ -36,6 +38,8 @@ public function implementsAtRule()
*/
public function implementsRenderable()
{
$this->setUpTestcase();

self::assertInstanceOf(Renderable::class, $this->subject);
}

Expand All @@ -44,6 +48,8 @@ public function implementsRenderable()
*/
public function implementsCommentable()
{
$this->setUpTestcase();

self::assertInstanceOf(Commentable::class, $this->subject);
}
}
38 changes: 37 additions & 1 deletion tests/OutputFormatTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ final class OutputFormatTest extends TestCase
*/
private $oDocument;

protected function setUp()
private function setUpTestcase()
{
$this->oParser = new Parser(self::TEST_CSS);
$this->oDocument = $this->oParser->parse();
Expand All @@ -54,6 +54,8 @@ protected function setUp()
*/
public function plain()
{
$this->setUpTestcase();

self::assertSame(
'.main, .test {font: italic normal bold 16px/1.2 "Helvetica",Verdana,sans-serif;background: white;}
@media screen {.main {background-size: 100% 100%;font-size: 1.3em;background-color: #fff;}}',
Expand All @@ -66,6 +68,8 @@ public function plain()
*/
public function compact()
{
$this->setUpTestcase();

self::assertSame(
'.main,.test{font:italic normal bold 16px/1.2 "Helvetica",Verdana,sans-serif;background:white;}'
. '@media screen{.main{background-size:100% 100%;font-size:1.3em;background-color:#fff;}}',
Expand All @@ -78,6 +82,8 @@ public function compact()
*/
public function pretty()
{
$this->setUpTestcase();

self::assertSame(self::TEST_CSS, $this->oDocument->render(OutputFormat::createPretty()));
}

Expand All @@ -86,6 +92,8 @@ public function pretty()
*/
public function spaceAfterListArgumentSeparator()
{
$this->setUpTestcase();

self::assertSame(
'.main, .test {font: italic normal bold 16px/ 1.2 '
. '"Helvetica", Verdana, sans-serif;background: white;}'
Expand All @@ -99,6 +107,8 @@ public function spaceAfterListArgumentSeparator()
*/
public function spaceAfterListArgumentSeparatorComplex()
{
$this->setUpTestcase();

self::assertSame(
'.main, .test {font: italic normal bold 16px/1.2 "Helvetica", Verdana, sans-serif;background: white;}'
. "\n@media screen {.main {background-size: 100% 100%;font-size: 1.3em;background-color: #fff;}}",
Expand All @@ -116,6 +126,8 @@ public function spaceAfterListArgumentSeparatorComplex()
*/
public function spaceAfterSelectorSeparator()
{
$this->setUpTestcase();

self::assertSame(
'.main,
.test {font: italic normal bold 16px/1.2 "Helvetica",Verdana,sans-serif;background: white;}
Expand All @@ -129,6 +141,8 @@ public function spaceAfterSelectorSeparator()
*/
public function stringQuotingType()
{
$this->setUpTestcase();

self::assertSame(
'.main, .test {font: italic normal bold 16px/1.2 \'Helvetica\',Verdana,sans-serif;background: white;}
@media screen {.main {background-size: 100% 100%;font-size: 1.3em;background-color: #fff;}}',
Expand All @@ -141,6 +155,8 @@ public function stringQuotingType()
*/
public function rGBHashNotation()
{
$this->setUpTestcase();

self::assertSame(
'.main, .test {font: italic normal bold 16px/1.2 "Helvetica",Verdana,sans-serif;background: white;}
@media screen {.main {background-size: 100% 100%;font-size: 1.3em;background-color: rgb(255,255,255);}}',
Expand All @@ -153,6 +169,8 @@ public function rGBHashNotation()
*/
public function semicolonAfterLastRule()
{
$this->setUpTestcase();

self::assertSame(
'.main, .test {font: italic normal bold 16px/1.2 "Helvetica",Verdana,sans-serif;background: white}
@media screen {.main {background-size: 100% 100%;font-size: 1.3em;background-color: #fff}}',
Expand All @@ -165,6 +183,8 @@ public function semicolonAfterLastRule()
*/
public function spaceAfterRuleName()
{
$this->setUpTestcase();

self::assertSame(
'.main, .test {font: italic normal bold 16px/1.2 "Helvetica",Verdana,sans-serif;background: white;}
@media screen {.main {background-size: 100% 100%;font-size: 1.3em;background-color: #fff;}}',
Expand All @@ -177,6 +197,8 @@ public function spaceAfterRuleName()
*/
public function spaceRules()
{
$this->setUpTestcase();

self::assertSame('.main, .test {
font: italic normal bold 16px/1.2 "Helvetica",Verdana,sans-serif;
background: white;
Expand All @@ -193,6 +215,8 @@ public function spaceRules()
*/
public function spaceBlocks()
{
$this->setUpTestcase();

self::assertSame('
.main, .test {font: italic normal bold 16px/1.2 "Helvetica",Verdana,sans-serif;background: white;}
@media screen {
Expand All @@ -206,6 +230,8 @@ public function spaceBlocks()
*/
public function spaceBoth()
{
$this->setUpTestcase();

self::assertSame('
.main, .test {
font: italic normal bold 16px/1.2 "Helvetica",Verdana,sans-serif;
Expand All @@ -226,6 +252,8 @@ public function spaceBoth()
*/
public function spaceBetweenBlocks()
{
$this->setUpTestcase();

self::assertSame(
'.main, .test {font: italic normal bold 16px/1.2 "Helvetica",Verdana,sans-serif;background: white;}'
. '@media screen {.main {background-size: 100% 100%;font-size: 1.3em;background-color: #fff;}}',
Expand All @@ -238,6 +266,8 @@ public function spaceBetweenBlocks()
*/
public function indentation()
{
$this->setUpTestcase();

self::assertSame('
.main, .test {
font: italic normal bold 16px/1.2 "Helvetica",Verdana,sans-serif;
Expand All @@ -261,6 +291,8 @@ public function indentation()
*/
public function spaceBeforeBraces()
{
$this->setUpTestcase();

self::assertSame(
'.main, .test{font: italic normal bold 16px/1.2 "Helvetica",Verdana,sans-serif;background: white;}
@media screen{.main{background-size: 100% 100%;font-size: 1.3em;background-color: #fff;}}',
Expand All @@ -273,6 +305,8 @@ public function spaceBeforeBraces()
*/
public function ignoreExceptionsOff()
{
$this->setUpTestcase();

$this->expectException(OutputException::class);

$aBlocks = $this->oDocument->getAllDeclarationBlocks();
Expand All @@ -292,6 +326,8 @@ public function ignoreExceptionsOff()
*/
public function ignoreExceptionsOn()
{
$this->setUpTestcase();

$aBlocks = $this->oDocument->getAllDeclarationBlocks();
$oFirstBlock = $aBlocks[0];
$oFirstBlock->removeSelector('.main');
Expand Down