[TASK] Configure PHPUnit to be more strict #743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added this to the 9.0.0: Drop support for PHP < 7.2 and clean up things milestone
oliverklee
added a commit
that referenced
this pull request
Oct 25, 2024
This is the v8.x backport of #743.
oliverklee
added a commit
that referenced
this pull request
Oct 25, 2024
This is the v8.x backport of #743.
oliverklee
force-pushed
the
task/phpunit-configuration
branch
from
77f9b0f to
3a95a1c
Compare
oliverklee
added a commit
that referenced
this pull request
Oct 25, 2024
This is the v8.x backport of #743.
JakeQZ
requested changes
Oct 25, 2024
There was a problem hiding this comment.
Changes seem mostly fine, but could we please keep the original indentation style. This would make the diff cleaner, and avoid attributes being idented by 9 spaces.
Also, do we need bootstrap="vendor/autoload.php". It seems to work without it, and must presumably be using that by default, otherwise the classes to be tested wouldn't load. Explicitly stating it creates a hard-coded value that makes assumptions about the behaviour of a third-party package (Composer itself). If PHPUnit effectively deals with the location of Composer's autoload file, then we should just allow it to do so.
oliverklee
added a commit
that referenced
this pull request
Oct 25, 2024
This is the v8.x backport of #743.
|
Done and repushed. |
JakeQZ
approved these changes
Oct 25, 2024
oliverklee
added a commit
that referenced
this pull request
Oct 26, 2024
This is the v8.x backport of #743.
oliverklee
added a commit
that referenced
this pull request
Oct 26, 2024
This is the v8.x backport of #743.
JakeQZ
pushed a commit
that referenced
this pull request
Oct 26, 2024
This is the v8.x backport of #743.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change brings the PHPUnit configuration in line with what we have at Emogrifier (except for the difference in the XSD version number).