Skip to content

[TASK] Clean up the code with Rector #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 11, 2024
Merged

[TASK] Clean up the code with Rector #772

merged 3 commits into from
Nov 11, 2024

Conversation

oliverklee
Copy link
Collaborator

@oliverklee oliverklee commented Nov 10, 2024

Just the Rector changes, and some redundancy removal related to those, but nothing more.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@oliverklee oliverklee requested a review from JakeQZ November 10, 2024 19:06
@coveralls
Copy link

coveralls commented Nov 10, 2024

Coverage Status

coverage: 38.583% (-0.04%) from 38.622%
when pulling bd8b907 on cleanup/rector
into 6026011 on main.

@oliverklee oliverklee removed the request for review from JakeQZ November 10, 2024 22:14
@oliverklee oliverklee marked this pull request as draft November 10, 2024 22:14
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good. But two of the changes compromise code readability, and could do with looking at in more detail.

@oliverklee oliverklee marked this pull request as ready for review November 11, 2024 08:27
Just the Rector changes, and some redundancy removal related to
those, but nothing more.
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat.

@JakeQZ JakeQZ merged commit 2c49003 into main Nov 11, 2024
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/rector branch November 11, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants