-
Notifications
You must be signed in to change notification settings - Fork 145
[TASK] Clean up the code with Rector #772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly good. But two of the changes compromise code readability, and could do with looking at in more detail.
43e100d
to
ada675d
Compare
Just the Rector changes, and some redundancy removal related to those, but nothing more.
ada675d
to
e031f14
Compare
e031f14
to
bd8b907
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat.
Just the Rector changes, and some redundancy removal related to those, but nothing more.