Conversation
MatthewScholefield
left a comment
MatthewScholefield
left a comment
Collaborator
There was a problem hiding this comment.
Cool! Looks mostly good to me. One thing, since the entire coninput is unrelated to audio processing, perhaps we should rename it to _coninput to make it explicit that it's an internal thing?
Also, nit: perhaps suffix Windows and POSIX with an identifier so like WindowsInput and POSIXInput.
Otherwise, lgtm, but I haven't tested locally yet.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Windows compatibility for training scripts so that #180 can move forward.