Skip to content

Set __version__ attribute dynamically in __init__.py#152

Merged
valeriupredoi merged 2 commits into
mainfrom
set_version_init
Nov 14, 2025
Merged

Set __version__ attribute dynamically in __init__.py#152
valeriupredoi merged 2 commits into
mainfrom
set_version_init

Conversation

@valeriupredoi

@valeriupredoi valeriupredoi commented Nov 13, 2025

Copy link
Copy Markdown
Collaborator

Description

A good chance to have a __version__ setter that is done via the package metadata, rather than hardcoded.

Before you get started

Checklist

  • This pull request has a descriptive title and labels
  • This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
  • Unit tests have been added (if codecov test fails)
  • Any changed dependencies have been added or removed correctly (if need be)
  • If you are working on the documentation, please ensure the current build passes
  • All tests pass

@codecov

codecov Bot commented Nov 13, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.18%. Comparing base (d3b26fd) to head (b796a04).
⚠️ Report is 182 commits behind head on main.

Files with missing lines Patch % Lines
pyfive/__init__.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
- Coverage   76.24%   76.18%   -0.07%     
==========================================
  Files          14       14              
  Lines        2888     2893       +5     
  Branches      459      459              
==========================================
+ Hits         2202     2204       +2     
- Misses        561      564       +3     
  Partials      125      125              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bnlawrence bnlawrence left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And we now know that the version that will appear now is the version of the github release tag. Where exactly does that go?

@valeriupredoi

Copy link
Copy Markdown
Collaborator Author

Where exactly does that go?

What do you mean? 🍺

@davidhassell davidhassell left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splendid

@valeriupredoi

Copy link
Copy Markdown
Collaborator Author

thank you both @davidhassell and @bnlawrence - BTW @davidhassell you can now access the development version (which is something like eg pyfive-1.1.0.dev2+gb796a04e4) - if you still see eg 0.10.guff, just do a pip install -e .

@valeriupredoi valeriupredoi merged commit 5d3438a into main Nov 14, 2025
6 of 7 checks passed
@valeriupredoi valeriupredoi deleted the set_version_init branch November 14, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants